Skip to content

Add builds for MSVC cccl_c_parallel #9605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miscco wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −1
Open

Add builds for MSVC cccl_c_parallel #9605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4870199
Add builds for MSVC cccl_c_parallel
miscco Jun 26, 2026
bde4d22
Merge branch 'main' into hostjit_windows_ci
miscco Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/matrix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ workflows:
#
# IMPORTANT: Do NOT delete or remove the `override:` key below, even when it is empty.
override:
- {jobs: ['test'], project: 'cccl_c_parallel_v2', ctk: '13.X', cxx: ['gcc13', 'msvc'], gpu: 'rtx2080'}

@coderabbitai coderabbitai Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

important: Line 25 should not be merged populated. workflows.override replaces the normal pull_request matrix, so this would permanently narrow PR coverage for unrelated changes and keep branch-protection red until someone clears it. Move this to a draft-only branch state and reset override: to empty before merge. As per coding guidelines, Override matrices block PR merges and must be reset to empty before merging; as per path instructions, for ci/**/* focus on matrix correctness and avoiding unnecessary expensive jobs.

Sources: Coding guidelines, Path instructions


pull_request:
# Old CTK: Oldest/newest supported host compilers:
Expand Down Expand Up @@ -79,7 +80,7 @@ workflows:
# Eventually v2 will replace v1 as the default and run across the
# entire matrix. Currently blocked on libnvfatbin availability on
# Windows containers, and for CUDA <12.4.
- {jobs: ['test'], project: 'cccl_c_parallel_v2', ctk: '13.X', cxx: ['gcc13'], gpu: 'rtx2080'}
- {jobs: ['test'], project: 'cccl_c_parallel_v2', ctk: '13.X', cxx: ['gcc13', 'msvc'], gpu: 'rtx2080'}
# Python against c.parallel v2 (HostJIT-based). Single point of coverage
# for the v2 Python path; the main `python` matrix continues to test
# against v1 until v2 replaces it.
Expand Down
28 changes: 28 additions & 0 deletions ci/windows/build_cccl_c_parallel_v2.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
Param(
[Parameter(Mandatory = $false)]
[Alias("arch")]
[string]$CUDA_ARCH = "",
[Parameter(Mandatory = $false)]
[Alias("cmake-options")]
[string]$CMAKE_OPTIONS = ""
)

$ErrorActionPreference = "Stop"

$CURRENT_PATH = Split-Path $pwd -leaf
If($CURRENT_PATH -ne "ci") {
Write-Host "Moving to ci folder"
pushd "$PSScriptRoot/.."
}
Comment on lines +12 to +16

@coderabbitai coderabbitai Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

important: Line 13 only checks the leaf name of the current directory. If this script is launched from any unrelated directory named ci, it skips the repo-local pushd and the subsequent configure/build runs against the wrong tree. Compare against the full $PSScriptRoot/.. path, or unconditionally Push-Location to it before importing/building. As per path instructions, for ci/**/* focus on environment setup and clear failures.

Source: Path instructions


Remove-Module -Name build_common -ErrorAction SilentlyContinue
Import-Module $PSScriptRoot/build_common.psm1 -ArgumentList @(20, $CUDA_ARCH, $CMAKE_OPTIONS)

$PRESET = "cccl-c-parallel-v2"
$LOCAL_CMAKE_OPTIONS = ""

configure_and_build_preset "CCCL C Parallel" $PRESET $LOCAL_CMAKE_OPTIONS

If($CURRENT_PATH -ne "ci") {
popd
}
Loading