Add builds for MSVC cccl_c_parallel#9605
Conversation
Updated hostjit CI to cover Windows/MSVC for
WalkthroughAdds a new Windows build script for cccl-c-parallel-v2 and updates CI matrices so that job runs on CUDA 13.X with gcc13 and msvc for rtx2080. ChangesWindows CI job wiring
Suggested reviewers
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5cb76448-9116-4e38-bcab-1142fc695938
📒 Files selected for processing (2)
ci/matrix.yamlci/windows/build_cccl_c_parallel_v2.ps1
| # | ||
| # IMPORTANT: Do NOT delete or remove the `override:` key below, even when it is empty. | ||
| override: | ||
| - {jobs: ['test'], project: 'cccl_c_parallel_v2', ctk: '13.X', cxx: ['gcc13', 'msvc'], gpu: 'rtx2080'} |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
important: Line 25 should not be merged populated. workflows.override replaces the normal pull_request matrix, so this would permanently narrow PR coverage for unrelated changes and keep branch-protection red until someone clears it. Move this to a draft-only branch state and reset override: to empty before merge. As per coding guidelines, Override matrices block PR merges and must be reset to empty before merging; as per path instructions, for ci/**/* focus on matrix correctness and avoiding unnecessary expensive jobs.
Sources: Coding guidelines, Path instructions
| $CURRENT_PATH = Split-Path $pwd -leaf | ||
| If($CURRENT_PATH -ne "ci") { | ||
| Write-Host "Moving to ci folder" | ||
| pushd "$PSScriptRoot/.." | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
important: Line 13 only checks the leaf name of the current directory. If this script is launched from any unrelated directory named ci, it skips the repo-local pushd and the subsequent configure/build runs against the wrong tree. Compare against the full $PSScriptRoot/.. path, or unconditionally Push-Location to it before importing/building. As per path instructions, for ci/**/* focus on environment setup and clear failures.
Source: Path instructions
This comment has been minimized.
This comment has been minimized.
😬 CI Workflow Results🟥 Finished in 6h 58m: Pass: 50%/2 | Total: 50m 24s | Max: 29m 48s | Hits: 99%/3207See results here. |
We want to test the hostjit CI also on windows