Skip to content

Add builds for MSVC cccl_c_parallel#9605

Open
miscco wants to merge 1 commit into
NVIDIA:mainfrom
miscco:hostjit_windows_ci
Open

Add builds for MSVC cccl_c_parallel#9605
miscco wants to merge 1 commit into
NVIDIA:mainfrom
miscco:hostjit_windows_ci

Conversation

@miscco

@miscco miscco commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

We want to test the hostjit CI also on windows

@miscco miscco requested a review from a team as a code owner June 26, 2026 08:43
@miscco miscco requested a review from jrhemstad June 26, 2026 08:43
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 26, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note: CodeRabbit is enabled on this repository as a convenience for maintainers
and contributors. Use your best judgment when considering its review comments and
suggestions — a suggested change may be inadequate, unnecessary, or safe to ignore.
Contributors are not expected to address every comment. Human reviews are what
ultimately matter for merging.

Updated hostjit CI to cover Windows/MSVC for cccl_c_parallel_v2.

  • Expanded ci/matrix.yaml so cccl_c_parallel_v2 now runs with both gcc13 and msvc on ctk: 13.X / gpu: rtx2080, including the PR override matrix.
  • Added ci/windows/build_cccl_c_parallel_v2.ps1 to support building that preset on Windows via the shared CI build logic.

Walkthrough

Adds a new Windows build script for cccl-c-parallel-v2 and updates CI matrices so that job runs on CUDA 13.X with gcc13 and msvc for rtx2080.

Changes

Windows CI job wiring

Layer / File(s) Summary
Build script entry point
ci/windows/build_cccl_c_parallel_v2.ps1
Adds optional CUDA arch and CMake options parameters, imports shared build logic, and runs the cccl-c-parallel-v2 preset after adjusting the working directory.
Matrix entries
ci/matrix.yaml
Updates the override and pull_request matrices for cccl_c_parallel_v2 on ctk: 13.X and gpu: rtx2080 with gcc13 and msvc in cxx.

Suggested reviewers

  • suggestion: bernhardmgruber
  • suggestion: jrhemstad

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5cb76448-9116-4e38-bcab-1142fc695938

📥 Commits

Reviewing files that changed from the base of the PR and between 8756dfc and 4870199.

📒 Files selected for processing (2)
  • ci/matrix.yaml
  • ci/windows/build_cccl_c_parallel_v2.ps1

Comment thread ci/matrix.yaml
#
# IMPORTANT: Do NOT delete or remove the `override:` key below, even when it is empty.
override:
- {jobs: ['test'], project: 'cccl_c_parallel_v2', ctk: '13.X', cxx: ['gcc13', 'msvc'], gpu: 'rtx2080'}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

important: Line 25 should not be merged populated. workflows.override replaces the normal pull_request matrix, so this would permanently narrow PR coverage for unrelated changes and keep branch-protection red until someone clears it. Move this to a draft-only branch state and reset override: to empty before merge. As per coding guidelines, Override matrices block PR merges and must be reset to empty before merging; as per path instructions, for ci/**/* focus on matrix correctness and avoiding unnecessary expensive jobs.

Sources: Coding guidelines, Path instructions

Comment on lines +12 to +16
$CURRENT_PATH = Split-Path $pwd -leaf
If($CURRENT_PATH -ne "ci") {
Write-Host "Moving to ci folder"
pushd "$PSScriptRoot/.."
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

important: Line 13 only checks the leaf name of the current directory. If this script is launched from any unrelated directory named ci, it skips the repo-local pushd and the subsequent configure/build runs against the wrong tree. Compare against the full $PSScriptRoot/.. path, or unconditionally Push-Location to it before importing/building. As per path instructions, for ci/**/* focus on environment setup and clear failures.

Source: Path instructions

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

😬 CI Workflow Results

🟥 Finished in 6h 58m: Pass: 50%/2 | Total: 50m 24s | Max: 29m 48s | Hits: 99%/3207

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant