Skip to content

fix(studio): Fix sometimes not being able to select an option on the Code Agent #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
htolentino-nvidia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(studio): Fix sometimes not being able to select an option on the Code Agent #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions web/packages/studio/src/components/agents/AgentBlockingInput/FilesetFileBlockingInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,15 @@ export const FilesetFileBlockingInput: FC<FilesetFileBlockingInputBaseProps> = (
control,
handleSubmit,
setError,
watch,
formState: { errors },
} = useForm<FilesetFileFormData>({
defaultValues: { datasetFile: null },
resolver: zodResolver(schema),
disabled: isSubmitting,
});
const acceptedFileTypes = getAcceptedFileTypes(input, defaultAcceptedFileTypes);
const datasetFile = watch('datasetFile');

const submit = handleSubmit((data) => {
const parsed =
Expand All @@ -98,6 +100,7 @@ export const FilesetFileBlockingInput: FC<FilesetFileBlockingInputBaseProps> = (
request={request}
secondaryActions={secondaryActions}
secondaryActionLabel={secondaryActionLabel}
submitDisabled={!datasetFile}
submitLabel={submitLabel}
>
<Stack className="max-h-[45vh] overflow-y-auto pr-density-sm">
Expand Down
6 changes: 3 additions & 3 deletions web/packages/studio/src/components/agents/AgentDecisionInput/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('AgentDecisionInput', () => {
);
});

it('shows a send button for the text choice and submits the entered text', async () => {
it('shows a send button that is disabled while a text choice awaits input', async () => {
const user = userEvent.setup();
const onSubmit = vi.fn();

Expand All @@ -129,13 +129,13 @@ describe('AgentDecisionInput', () => {
/>
);

expect(screen.queryByRole('button', { name: /Send alternative instruction/i })).toBeNull();
const sendButton = screen.getByRole('button', { name: /Send/i });
expect(sendButton).not.toBeDisabled();

await user.click(
screen.getByRole('option', { name: /3\.\s+Tell the Agent what to do differently/i })
);

const sendButton = screen.getByRole('button', { name: /Send alternative instruction/i });
expect(sendButton).toBeDisabled();

await user.type(
Expand Down
24 changes: 11 additions & 13 deletions web/packages/studio/src/components/agents/AgentDecisionInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,19 +367,17 @@ export const AgentDecisionInput = ({
<Text kind="label/regular/sm">{skipLabel}</Text>
</Button>
) : null}
{selectedChoiceInput ? (
<Button
aria-label="Send alternative instruction"
type="button"
color="brand"
size="small"
disabled={isSubmitting || !trimmedChoiceInputValue}
className={subduedButtonFocusClassName}
onClick={() => void submitSelectedChoice()}
>
<Send size={16} />
</Button>
) : null}
<Button
aria-label="Send"
type="button"
color="brand"
size="small"
disabled={isSubmitting || (!!selectedChoiceInput && !trimmedChoiceInputValue)}
className={subduedButtonFocusClassName}
onClick={() => void submitSelectedChoice()}
>
<Send size={16} />
</Button>
</Flex>
</Flex>
</Flex>
Expand Down