Skip to content

fix(studio): Fix sometimes not being able to select an option on the Code Agent#490

Open
htolentino-nvidia wants to merge 1 commit into
mainfrom
studio-fix-code-agent-input/htolentino
Open

fix(studio): Fix sometimes not being able to select an option on the Code Agent#490
htolentino-nvidia wants to merge 1 commit into
mainfrom
studio-fix-code-agent-input/htolentino

Conversation

@htolentino-nvidia

@htolentino-nvidia htolentino-nvidia commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • The send action in decision flows is now always visible and clearly labeled.
    • Users can no longer submit until required input is provided or a file is selected.
  • Bug Fixes

    • Improved disabled-state behavior for send actions to better reflect when a choice is ready to submit.
    • File-based blocking inputs now prevent submission until a dataset file is chosen.

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia htolentino-nvidia requested review from a team as code owners June 26, 2026 20:06
@github-actions github-actions Bot added the fix label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 82e08d7c-c2a8-42a5-9f14-72592a73b249

📥 Commits

Reviewing files that changed from the base of the PR and between 312c2bc and 9dc2e8d.

📒 Files selected for processing (3)
  • web/packages/studio/src/components/agents/AgentBlockingInput/FilesetFileBlockingInput.tsx
  • web/packages/studio/src/components/agents/AgentDecisionInput/index.test.tsx
  • web/packages/studio/src/components/agents/AgentDecisionInput/index.tsx

📝 Walkthrough

Walkthrough

Agent decision inputs now always show a Send button with input-aware disabled state, and fileset blocking inputs now disable submission until a dataset file is selected. Related tests were updated for the new send-button behavior.

Changes

Agent input submit gating

Layer / File(s) Summary
Decision send button
web/packages/studio/src/components/agents/AgentDecisionInput/index.tsx, web/packages/studio/src/components/agents/AgentDecisionInput/index.test.tsx
AgentDecisionInput now keeps a Send button visible and disables it based on submitting state and trimmed input; the test assertions were updated to match the new button flow.
Dataset file submit gate
web/packages/studio/src/components/agents/AgentBlockingInput/FilesetFileBlockingInput.tsx
FilesetFileBlockingInput now watches datasetFile and passes submitDisabled={!datasetFile} to AgentBlockingInputFrame.

Suggested reviewers

  • steramae-nvidia
  • dmariali
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main fix: users can now select/submit Code Agent options when inputs are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch studio-fix-code-agent-input/htolentino

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 21322/27924 76.4% 61.4%
Integration Tests 12353/26693 46.3% 19.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant