fix(domains): Read MASKTABLE parameter when AUTO_MASKTABLE is enabled - #1181
Open
johnpaulalex wants to merge 1 commit into
Open
fix(domains): Read MASKTABLE parameter when AUTO_MASKTABLE is enabled#1181johnpaulalex wants to merge 1 commit into
johnpaulalex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
MOM_domains_init, whenAUTO_MASKTABLEis.true., MOM6 previously hardcoded the auto-generated mask table filename to"MOM_auto_mask_table".This change updates
MOM_domains_initto query theMASKTABLEruntime parameter fromparam_file(with fallback default"MOM_auto_mask_table"), which also enables instance-suffixed mask table filenames (e.g.,MOM_auto_mask_table_0001,MOM_auto_mask_table_0002).Details: rather than a separate code branch which hardcodes
"MOM_auto_mask_table", now there is a single unified get_param call to readMASKTABLE.All answers are expected to be bitwise identical for single-instance runs.
Resolves ESCOMP/MOM_interface#269 when combined with sibling PR ESCOMP/MOM_interface#348 which changes CESM's defaults to use instance-suffixed filenames. See the other PR for description of why the PRs can be released in any order.
Google Antigravity was used to write the code and tests, followed by human-guided verification.