fix(templates): Use instance-suffixed MASKTABLE for AUTO_MASKTABLE runs - #348
Open
johnpaulalex wants to merge 1 commit into
Open
fix(templates): Use instance-suffixed MASKTABLE for AUTO_MASKTABLE runs#348johnpaulalex wants to merge 1 commit into
johnpaulalex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes default MASKTABLE for auto_masktable runs to be instance-suffixed, resolving file collisions for multi-instance runs (Issue #269).
Main changes:
MASKTABLEruntime parameter definition intoparam_templates/MOM_input.yaml, superseding the old fortran defaults. The non-AUTO_MASKTABLE default is effectively unchanged (still a single file shared across all instances), while the AUTO_MASKTABLE case is now defaulted to have an instance suffix, which fixes the file writing collisions.tests/check_buildnml.pyverifyingMASKTABLEexpansion across single and multi-instance modes.SMS_C2system tests (with AUTO_MASKTABLE on and off) tocime_config/testdefs/testlist_mom.xml. Note the non-auto-masktable version won't find the static masktable file so it runs in unmasked mode.This PR relies on NOAA-GFDL/MOM6#1181 to actually use the MASKTABLE parameter in the AUTO_MASKTABLE case.
Note the PRs can be submitted in either order:
Resolves #269 (once CESM points to a version of MOM6 with its PR live as well)
Testing:
tests/check_default_params.py: PASS (yaml translates to json correctly)tests/check_buildnml.py: PASSaux_mom.derecho(System tests): both new C2 tests passed, see/glade/derecho/scratch/jpalex/cs.status.issue269_v4. (I also ran the rest of aux_mom, which ran fine but didn't do any baseline diffing - please lmk if there's an incantation to do that)Google Antigravity was used to write the code and tests, followed by human-guided verification.