Skip to content

+Add RHO_OCEAN_SAL #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hallberg-NOAA wants to merge 1 commit into
base: dev/gfdl
Choose a base branch
from
Open

+Add RHO_OCEAN_SAL #1172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/parameterizations/lateral/MOM_self_attr_load.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ subroutine SAL_init(h, tv, G, GV, US, param_file, CS, restart_CS)
character(len=40) :: mdl = "MOM_self_attr_load" ! This module's name.
integer :: lmax ! Total modes of the real spherical harmonics [nondim]
real :: rhoE ! The average density of Earth [R ~> kg m-3].
real :: rho_ocean_SAL ! The mean ocean density used for calculating the
! self-attraction and loading [R ~> kg m-3]
character(len=20) :: bpa_config ! String for reference bottom pressure config option
real :: tmp(G%isd:G%ied, G%jsd:G%jed) ! Temporary field storing mass returned by find_col_mass
! [R Z ~> kg m-2]
Expand Down Expand Up @@ -305,8 +307,14 @@ subroutine SAL_init(h, tv, G, GV, US, param_file, CS, restart_CS)
default=0, do_not_log=(.not. CS%use_sal_sht))
call get_param(param_file, mdl, "RHO_SOLID_EARTH", rhoE, &
"The mean solid earth density. This is used for calculating the "// &
"self-attraction and loading term.", units="kg m-3", &
default=5517.0, scale=US%kg_m3_to_R, do_not_log=(.not. CS%use_sal_sht))
"self-attraction and loading term.", &
units="kg m-3", default=5517.0, scale=US%kg_m3_to_R, &
do_not_log=(.not. CS%use_sal_sht))
call get_param(param_file, mdl, "RHO_OCEAN_SAL", rho_ocean_SAL, &

@herrwang0 herrwang0 Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

! rho_ocean_SAL is only used to (neither case is recommended)
! (1) convert SSH to BPA with the scalar approximation when SAL_USE_BPA is true.
! (2) convert BPA to SSH with the spherical harmonics when SAL_USE_BPA is false.
use_rho_ocean_SAL = (((CS%use_sal_scalar .or. CS%use_tidal_sal_prev) .and. CS%use_bpa) .or. &
                     (CS%use_sal_sht .and. (.not.CS%use_bpa)))
call get_param(param_file, mdl, "RHO_OCEAN_SAL", rho_ocean_SAL, &
               "The mean ocean density used to convert between bottom pressure anomalies "//&
               "and the equivalent sea surface height anomalies in the self-attraction and "//&
               "loading calculations.  This is only used with the scalar approximation when "//&
               "SAL_USE_BPA is true, or with SAL_HARMONICS when SAL_USE_BPA is false.", &
               units="kg m-3", default=US%R_to_kg_m3*GV%Rho0, scale=US%kg_m3_to_R, &
               do_not_log=.not.use_rho_ocean_SAL)

"The mean ocean density used for calculating the self-attraction and loading.", &
units="kg m-3", default=US%R_to_kg_m3*GV%Rho0, scale=US%kg_m3_to_R, &
do_not_log=.not.(CS%use_sal_sht.or.CS%use_bpa))

@herrwang0 herrwang0 Sep 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra blank line.


! Set scaling coefficients for scalar approximation
if (CS%use_sal_scalar .or. CS%use_tidal_sal_prev) then
Expand All @@ -316,7 +324,7 @@ subroutine SAL_init(h, tv, G, GV, US, param_file, CS, restart_CS)
CS%eta_prop = sal_scalar_value
endif
if (CS%use_bpa) then
CS%linear_scaling = CS%eta_prop / (GV%Rho0 * GV%g_Earth)
CS%linear_scaling = CS%eta_prop / (rho_ocean_SAL * GV%g_Earth)
else
CS%linear_scaling = CS%eta_prop
endif
Expand All @@ -331,7 +339,7 @@ subroutine SAL_init(h, tv, G, GV, US, param_file, CS, restart_CS)
allocate(CS%Snm_Im(lmax), source=0.0)

allocate(CS%Love_scaling(lmax), source=0.0)
call calc_love_scaling(GV%Rho0, rhoE, GV%g_Earth, CS)
call calc_love_scaling(rho_ocean_SAL, rhoE, GV%g_Earth, CS)

allocate(CS%sht)
call spherical_harmonics_init(G, param_file, CS%sht)
Expand Down
Loading