+Add RHO_OCEAN_SAL - #1172
Conversation
Added the new runtime parameter RHO_OCEAN_SAL to set the mean ocean density used for the tidal self-attraction and loading calculations when SAL_USE_BPA or SAL_HARMONICS is true. The Boussinesq reference density had previously been used for these purposes, and it provides the default value for this new parameter. By default, all answers are bitwise identical but there is a new runtime parameter in cases that use certain types of tidal self-attraction and loading.
|
Thanks for looking into this. I agree a standalone density
|
|
@herrwang0, could you please clarify whether you think that we should go ahead with this PR or not? I am OK with either answer, but your previous comment was vague on this important point. |
herrwang0
left a comment
There was a problem hiding this comment.
Sorry for the ambiguity — yes, I think we should go ahead with this PR.
My suggestion is to document when and where RHO_OCEAN_SAL is used and only log this parameter when it is actually used (see comment above).
| "The mean ocean density used for calculating the self-attraction and loading.", & | ||
| units="kg m-3", default=US%R_to_kg_m3*GV%Rho0, scale=US%kg_m3_to_R, & | ||
| do_not_log=.not.(CS%use_sal_sht.or.CS%use_bpa)) | ||
|
|
| "self-attraction and loading term.", & | ||
| units="kg m-3", default=5517.0, scale=US%kg_m3_to_R, & | ||
| do_not_log=(.not. CS%use_sal_sht)) | ||
| call get_param(param_file, mdl, "RHO_OCEAN_SAL", rho_ocean_SAL, & |
There was a problem hiding this comment.
How about this?
! rho_ocean_SAL is only used to (neither case is recommended)
! (1) convert SSH to BPA with the scalar approximation when SAL_USE_BPA is true.
! (2) convert BPA to SSH with the spherical harmonics when SAL_USE_BPA is false.
use_rho_ocean_SAL = (((CS%use_sal_scalar .or. CS%use_tidal_sal_prev) .and. CS%use_bpa) .or. &
(CS%use_sal_sht .and. (.not.CS%use_bpa)))
call get_param(param_file, mdl, "RHO_OCEAN_SAL", rho_ocean_SAL, &
"The mean ocean density used to convert between bottom pressure anomalies "//&
"and the equivalent sea surface height anomalies in the self-attraction and "//&
"loading calculations. This is only used with the scalar approximation when "//&
"SAL_USE_BPA is true, or with SAL_HARMONICS when SAL_USE_BPA is false.", &
units="kg m-3", default=US%R_to_kg_m3*GV%Rho0, scale=US%kg_m3_to_R, &
do_not_log=.not.use_rho_ocean_SAL)
Added the new runtime parameter
RHO_OCEAN_SALto set the mean ocean density used for the tidal self-attraction and loading calculations whenSAL_USE_BPAorSAL_HARMONICSis true. The Boussinesq reference density had previously been used for these purposes, and it provides the default value for this new parameter. By default, all answers are bitwise identical but there is a new runtime parameter in cases that use certain types of tidal self-attraction and loading.