Skip to content

Add geoidchange as a field passed back to MALI #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hollyhan merged 2 commits into from
Jun 15, 2026
Merged

Add geoidchange as a field passed back to MALI #12

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0acd453
Add geoidchange as a field passed back to MALI
matthewhoffman Jun 8, 2026
d275266
Add logic to check that calcRG is active
matthewhoffman Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sl_model_mod.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,13 +827,14 @@ subroutine sl_solver_init(itersl, starttime, mali_iceload, mali_bedrock, mali_ma
end subroutine sl_solver_init

!========================================================================================================================
subroutine sl_solver(itersl, iter, dtime, starttime, mali_iceload, mali_mask, slchange)
subroutine sl_solver(itersl, iter, dtime, starttime, mali_iceload, mali_mask, slchange, geoidchange)
! Compute sea-level change associated with past ice loading changes

real :: starttime
integer :: iter, itersl, dtime
real, dimension(:,:), optional :: mali_iceload, mali_mask ! variables for coupled ISM-SLM simulations
real, dimension(:,:), intent(out), optional :: slchange ! variable exchanged with the ISM
real, dimension(:,:), intent(out), optional :: geoidchange ! variable exchanged with the ISM

!===========================================================
! BEGIN TIMING & EXECUTION
Expand Down Expand Up @@ -1555,6 +1556,7 @@ subroutine sl_solver(itersl, iter, dtime, starttime, mali_iceload, mali_mask, sl
! this is the information passed to the ice sheet model
!call write_sl(topoxy_m1(:,:)-topoxy(:,:), 'bedrock', folder_coupled)
slchange = topoxy_m1(:,:)-topoxy(:,:)
geoidchange = deltaslxy(:,:)+rr(:,:,nfiles)

@hollyhan hollyhan Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments:

  1. In the current form of the code, the decomposition of deltaslxy (total sea-level change) into rr (solid Earth elevation change) and gg (geoid change) only happens when calcRG is turned on. So including geoidchange = deltaslxy(:,:)+rr(:,:,nfiles) under if (coupling) statement will fail unless calcRG is turned on at the same time. If we are making the passing of geoidchange we should make sure to freeze the calcRG option tbe always true on namelist.sealevel

  2. it can just be geoidchange = gg(:,:,nfiles)

!write out the current ice load as a new file
call write_sl(icexy(:,:,nfiles), icemodel_out, outputfolder_ice, suffix=numstr)
endif !endif coupling
Expand Down