Add geoidchange as a field passed back to MALI - #12
Conversation
This commit modifies the main sl_solver routine to optionally pass back a geoidchange field. This allows it to be passed to MALI when run in coupled mode.
|
This PR was created to support this update in MALI: MALI-Dev/E3SM#180 |
hollyhan
left a comment
hollyhan
left a comment
There was a problem hiding this comment.
@matthewhoffman , thanks for making these changes!
I made a couple of comments before approving.
| ! this is the information passed to the ice sheet model | ||
| !call write_sl(topoxy_m1(:,:)-topoxy(:,:), 'bedrock', folder_coupled) | ||
| slchange = topoxy_m1(:,:)-topoxy(:,:) | ||
| geoidchange = deltaslxy(:,:)+rr(:,:,nfiles) |
There was a problem hiding this comment.
A couple of comments:
-
In the current form of the code, the decomposition of deltaslxy (total sea-level change) into rr (solid Earth elevation change) and gg (geoid change) only happens when calcRG is turned on. So including geoidchange = deltaslxy(:,:)+rr(:,:,nfiles) under if (coupling) statement will fail unless calcRG is turned on at the same time. If we are making the passing of geoidchange we should make sure to freeze the calcRG option tbe always true on namelist.sealevel
-
it can just be geoidchange = gg(:,:,nfiles)
2 participants
This commit modifies the main sl_solver routine to optionally pass back a geoidchange field. This allows it to be passed to MALI when run in coupled mode.