Skip to content

Typo in configuration.md#46

Open
iooner wants to merge 1 commit into
Leantime:masterfrom
iooner:patch-1
Open

Typo in configuration.md#46
iooner wants to merge 1 commit into
Leantime:masterfrom
iooner:patch-1

Conversation

@iooner

@iooner iooner commented Oct 5, 2025

Copy link
Copy Markdown

Small typo OpenID-Conenct > OpenID-Connect

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees)

Intent: Fixes the OpenID-ConenctOpenID-Connect heading typo in installation/configuration.md.

Change requests:

  1. Duplicate — recommend closing in favor of Fix typos in configuration.md #45. This exact one-line fix (configuration.md:176) is included verbatim in Fix typos in configuration.md #45, which also fixes ~15 other typos in the same file. Merging both will conflict. The fix itself is correct:
    • installation/configuration.md:176## OpenID-Connect (OIDC) Configuration
  2. No other changes requested — the diff is otherwise clean and scoped.

Acceptance checklist (must pass before merge):

  1. Decide dedupe: close this as superseded by Fix typos in configuration.md #45, or merge this first and rebase Fix typos in configuration.md #45 on top (pick one to avoid a merge conflict).
  2. CLA signed / green.
  3. N/A — no schema/API/behavior change (docs typo only).

CI status: No test gate for a docs typo. Only real gate is CLA. The dedupe decision vs #45 is the blocker, not CI.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review — status: ready-but-duplicate (advisory) · priority: P3 · next action: maintainer decide vs #45 · owner: @marcelfolaron

1. Intent: Fixes the "OpenID-Conenct" → "OpenID-Connect" typo in installation/configuration.md.

2. Change requests: None on the content — the single-line change at installation/configuration.md:176 is correct:

-## OpenID-Conenct (OIDC) Configuration
+## OpenID-Connect (OIDC) Configuration

However, this exact change is a strict subset of #45, which fixes this same line plus ~15 other typos in the same file. Recommend merging #45 and closing this one as included, or merging this first and rebasing #45. Merging both will cause a conflict on this line.

3. Acceptance checklist (must pass before merge):

  • Decide ordering vs Fix typos in configuration.md #45 to avoid a merge conflict on configuration.md:176
  • Docs build/link-check CI green
  • No behavior change — docs-only, no test required

4. CI status: Not readable through my current tooling — confirm green in the UI. No test gap (docs typo).

Advisory review only — not an approval. Merge authority stays with @marcelfolaron / @broskees.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees) · first review · full diff read at head 26a0b3b · open since 2025-10-05 (>14 days, flagged for age) · first-time contributor 👋

1. Intent: Fixes the OIDC section heading typo in installation/configuration.mdOpenID-ConenctOpenID-Connect.

2. Change requests: None. The heading fix (installation/configuration.md:176) is correct. ✔ One coordination note: PR #45 also edits installation/configuration.md and fixes this same OpenID-Conenct heading (among many other typos in the file). These two will conflict — #45 is a superset of this change. Recommend merging #45 (the broader cleanup) and closing this as covered-by, OR merging this first and rebasing #45. Don't merge both blind.

3. Acceptance checklist (must pass before merge):

  1. Decide Fix typos in configuration.md #45-vs-Typo in configuration.md #46 overlap (this heading fix is contained in Fix typos in configuration.md #45) so the same line isn't touched twice.
  2. Page renders cleanly (single-word heading change — safe).
  3. First-time contributor — worth a 👍 either way, even if the change lands via Fix typos in configuration.md #45.

4. CI status: No code/test surface — docs-only. No blockers beyond the #45 overlap. Open since Oct 2025 — resolve this cycle.

Advisory review only — not an approval, and I am not marking this ready or merging. Merge authority stays with @marcelfolaron / @broskees.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees) · flagged in today's sweep as a long-open, never-reviewed PR (opened 2025-10-05, >14 days) from a first-time contributor · reviewed at head 26a0b3b

1. Intent: Single typo fix in configuration.mdOpenID-ConenctOpenID-Connect.

2. Change requests:

  1. Duplicate of Fix typos in configuration.md #45. PR Fix typos in configuration.md #45 (also open) fixes this exact OpenID-Conenct typo plus several others in the same file. Recommend merging Fix typos in configuration.md #45 (the superset) and closing this one as a duplicate with thanks — or, if Fix typos in configuration.md #45's "site name" change is unwanted, cherry-pick this narrower fix instead. Either way both shouldn't merge (the second will conflict/no-op). Cross-linking rather than duplicating work.

3. Acceptance checklist (must pass before merge):

  1. Decide Fix typos in configuration.md #45-vs-Typo in configuration.md #46 (prefer Fix typos in configuration.md #45 as the superset); close the other as duplicate.
  2. Docs site builds.
  3. N/A — no code/schema/API change.

4. CI status: No readable CI gate; prose-only. No blocker beyond the dedupe decision + maintainer merge. Thanks for catching it, @iooner.

Advisory only — not an approval. Merge authority stays with @marcelfolaron / @broskees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants