Skip to content

fixing minor spelling mistake#44

Open
Eiernase wants to merge 1 commit into
Leantime:masterfrom
Eiernase:patch-1
Open

fixing minor spelling mistake#44
Eiernase wants to merge 1 commit into
Leantime:masterfrom
Eiernase:patch-1

Conversation

@Eiernase

Copy link
Copy Markdown

Pacakge

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees)

Intent: Fixes the PacakgePackage spelling in the bullet describing package-based installation in installation/system-requirements.md.

Change requests: None — the single-line diff is correct and scoped.

  • installation/system-requirements.md:5Package based installation reads correctly. ✔

Note: this is the oldest open PR in this repo (opened 2025-07-28, ~344 days) and is trivially safe; recommend prioritizing it to clear the backlog.

Acceptance checklist (must pass before merge):

  1. CLA signed / green (first-time contributor).
  2. Rendered docs page shows the corrected word with no Markdown breakage.
  3. N/A — no schema/API/behavior change (docs typo only).

CI status: No CI test gate applies to a docs typo; only the CLA/first-time-contributor check is relevant. Not a blocker beyond CLA.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review — status: ready (advisory) · priority: P3 · next action: maintainer merge · owner: @marcelfolaron

Thanks for the fix, and apologies this sat so long — this is the oldest open PR in the repo (opened 2025-07-28).

1. Intent: Corrects the spelling of "Pacakge" → "Package" in installation/system-requirements.md.

2. Change requests: None. The one-line diff at installation/system-requirements.md:5 is correct and self-contained:

-- **Pacakge based installation** requires a Linux Distribution, preferably Ubuntu 20.04+.
+- **Package based installation** requires a Linux Distribution, preferably Ubuntu 20.04+.

3. Acceptance checklist (must pass before merge):

  • Docs build/link-check CI green (or, if docs has no CI, a maintainer eyeballs the rendered page)
  • No behavior change — docs-only, so no test required
  • Confirm this doesn't conflict with fixed install links #51 (which also edits installation/) — different file, so should be clean

4. CI status: I can't read check-run status through my current tooling this cycle, so please confirm CI is green in the GitHub UI before merging. No behavior change and no tests are needed for a docs typo, so the missing-tests-is-a-blocker rule does not apply here.

Advisory review only — not an approval. Merge authority stays with @marcelfolaron / @broskees.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees) · first review · full diff read at head cdc4847 · open since 2025-07-28 (>14 days — oldest open docs PR, flagged for age) · first-time contributor 👋

1. Intent: Fixes a single spelling typo in installation/system-requirements.mdPacakgePackage.

2. Change requests: None. The one-word fix (installation/system-requirements.md:5) is correct and the surrounding sentence is unchanged. ✔

3. Acceptance checklist (must pass before merge):

  1. Docs site builds/renders the page (no broken markdown) — trivially true for a single-word text change.
  2. No other instance of Pacakge remains in the file (there isn't — this was the only one).
  3. Contributor is a first-timer — a quick 👍 + merge is the right call; a clean typo fix like this is exactly the kind of low-risk contribution to land promptly so it doesn't sit for a year.

4. CI status: No code/test surface — docs-only. No blockers. This has been open since July 2025; recommend merging or closing this cycle to clear the aged-PR backlog.

Advisory review only — not an approval, and I am not marking this ready or merging. Merge authority stays with @marcelfolaron / @broskees.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees) · flagged in today's sweep as a long-open, never-reviewed PR (opened 2025-07-28, >14 days) from a first-time contributor · reviewed at head cdc4847

1. Intent: Single-word spelling fix — "Pacakge" → "Package" in the installation docs.

2. Change requests: None. This is a trivial, correct typo fix with no functional impact. Thank you for the contribution, @Eiernase.

3. Acceptance checklist (must pass before merge):

  1. The corrected word reads "Package" and no surrounding text was altered.
  2. Docs site builds (this repo renders to docs.leantime.io) — a one-word Markdown change is build-safe.
  3. N/A — no code, schema, or API change.

4. CI status: No CI gate on this docs repo that I can read; a prose-only typo fix needs none. The only thing blocking this is a maintainer merge — it's been open since July 2025. Recommend batching it with the other open docs typo PRs (#45, #46, #47, #48, #51) in one merge pass to clear the docs backlog.

Advisory only — not an approval. Merge authority stays with @marcelfolaron / @broskees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants