Skip to content

Move single-module classes out of api into their owning modules - #8248

Merged
labkey-adam merged 3 commits into
developfrom
fb_move_from_api
Oct 30, 2026
Merged

labkey-adam merged 3 commits into
developfrom
fb_move_from_api

Conversation

@labkey-adam

@labkey-adam labkey-adam commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

Shrink the api module by moving classes that only one module uses into that module, so they no longer compile on the api build path that every module waits on.

Each moved class takes its owning module's package (e.g. org.labkey.api.reader.XMLStreamReaderWrapper → org.labkey.ms2.reader.XMLStreamReaderWrapper); the two that move into a module API keep their package. Classes referenced by name from Spring XML, labkey.tld, or client code stay in api, as do classes that rely on package-private or protected access to api internals.

Related Pull Requests

Changes

  • Move api classes and JSPs used by a single platform module into core, query, experiment, study, pipeline, survey, assay, filecontent, search, wiki, and visualization
  • Move two classes into the assay and study module APIs
  • Move unit and integration test registrations for moved classes from ApiModule to their new modules
  • Remove unused classes
  • Move several classes from the study module to the specimen module

@labkey-adam
labkey-adam merged commit db49a29 into develop Oct 30, 2026
7 of 11 checks passed
@labkey-adam
labkey-adam deleted the fb_move_from_api branch October 30, 2026 00:08
labkey-adam added a commit to LabKey/customModules that referenced this pull request Oct 30, 2026
## Rationale
Shrink the api module by moving classes that only one module uses into
that module, so they no longer compile on the api build path every
module waits on.

## Related Pull Requests
- LabKey/platform#8248

## Changes
- Move api classes used only by specimen and studydesign into those
modules

<!-- list of standard tasks (remove this comment to enable)
## Tasks
- [ ] Claude Code Review
- [ ] Manual Testing
- [ ] Test Automation
- [ ] Verify Fix
-->
labkey-adam added a commit to LabKey/snprcEHRModules that referenced this pull request Oct 30, 2026
## Rationale
Shrink the api module by moving classes that only one module uses into
that module, so they no longer compile on the api build path every
module waits on.

## Related Pull Requests
- LabKey/platform#8248

## Changes
- Move an api class used only by snprc_ehr into the module

<!-- list of standard tasks (remove this comment to enable)
## Tasks
- [ ] Claude Code Review
- [ ] Manual Testing
- [ ] Test Automation
- [ ] Verify Fix
-->
labkey-adam added a commit to LabKey/targetedms that referenced this pull request Oct 30, 2026
## Rationale
Shrink the api module by moving classes that only one module uses into
that module, so they no longer compile on the api build path every
module waits on.

## Related Pull Requests
- LabKey/platform#8248

## Changes
- Move api classes used only by targetedms into the module

<!-- list of standard tasks (remove this comment to enable)
## Tasks
- [ ] Claude Code Review
- [ ] Manual Testing
- [ ] Test Automation
- [ ] Verify Fix
-->
labkey-adam added a commit to LabKey/testAutomation that referenced this pull request Oct 30, 2026
## Rationale
Shrink the api module by moving classes that only one module uses into
that module, so they no longer compile on the api build path every
module waits on.

## Related Pull Requests
- LabKey/platform#8248

## Changes
- Move an api class used only by devtools into the module

<!-- list of standard tasks (remove this comment to enable)
## Tasks
- [ ] Claude Code Review
- [ ] Manual Testing
- [ ] Test Automation
- [ ] Verify Fix
-->
labkey-adam added a commit to LabKey/OConnorLabModules that referenced this pull request Oct 30, 2026
## Rationale
Shrink the api module by moving classes that only one module uses into
that module, so they no longer compile on the api build path every
module waits on.

## Related Pull Requests
- LabKey/platform#8248

## Changes
- Move api classes used only by genotyping and OConnorExperiments into
those modules; register the moved test in GenotypingModule

<!-- list of standard tasks (remove this comment to enable)
## Tasks
- [ ] Claude Code Review
- [ ] Manual Testing
- [ ] Test Automation
- [ ] Verify Fix
-->
labkey-adam added a commit to LabKey/commonAssays that referenced this pull request Oct 30, 2026
## Rationale
Shrink the api module by moving classes that only one module uses into
that module, so they no longer compile on the api build path every
module waits on.

## Related Pull Requests
- LabKey/platform#8248

## Changes
- Move api classes used only by ms2, flow, nab, and protein into those
modules

<!-- list of standard tasks (remove this comment to enable)
## Tasks
- [ ] Claude Code Review
- [ ] Manual Testing
- [ ] Test Automation
- [ ] Verify Fix
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants