Repository navigation
Move single-module classes out of api into their owning modules - #221
Merged
Merged
Conversation
labkey-klum
approved these changes
Oct 29, 2026
labkey-adam
added a commit
to LabKey/platform
that referenced
this pull request
Oct 30, 2026
## Rationale Shrink the api module by moving classes that only one module uses into that module, so they no longer compile on the api build path that every module waits on. Each moved class takes its owning module's package (e.g. `org.labkey.api.reader.XMLStreamReaderWrapper` → `org.labkey.ms2.reader.XMLStreamReaderWrapper`); the two that move into a module API keep their package. Classes referenced by name from Spring XML, `labkey.tld`, or client code stay in api, as do classes that rely on package-private or protected access to api internals. ## Related Pull Requests - LabKey/premiumModules#830 - LabKey/commonAssays#1098 - LabKey/customModules#291 - LabKey/OConnorLabModules#221 - LabKey/targetedms#1300 - LabKey/limsModules#2573 - LabKey/testAutomation#3272 - LabKey/snprcEHRModules#1028 ## Changes - Move api classes and JSPs used by a single platform module into core, query, experiment, study, pipeline, survey, assay, filecontent, search, wiki, and visualization - Move two classes into the assay and study module APIs - Move unit and integration test registrations for moved classes from ApiModule to their new modules - Remove unused classes - Move several classes from the study module to the specimen module <!-- list of standard tasks (remove this comment to enable) ## Tasks - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Shrink the api module by moving classes that only one module uses into that module, so they no longer compile on the api build path every module waits on.
Related Pull Requests
Changes