Skip to content

Refactor: Remove Hardcoded Mock Rivalry Data from TopRivalriesTicker #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmdeveloper007 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −49
Open

Refactor: Remove Hardcoded Mock Rivalry Data from TopRivalriesTicker #8756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 1 addition & 49 deletions components/TopRivalriesTicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,8 @@
'use client';

import { motion } from 'framer-motion';
import { Flame, Star, Swords, Target, Trophy, Zap } from 'lucide-react';
import { useRouter } from 'next/navigation';

const MOCK_RIVALRIES = [
{
u1: 'torvalds',
u2: 'gaearon',
label: 'Kernel vs React',
icon: Flame,
color: 'text-orange-500',
},
{
u1: 'rich-harris',
u2: 'antfu',
label: 'Svelte vs Nuxt',
icon: Zap,
color: 'text-yellow-400',
},
{
u1: 'shadcn',
u2: 'pacocoursey',
label: 'UI Masters',
icon: Target,
color: 'text-indigo-400',
},
{
u1: 'rauchg',
u2: 'biilmann',
label: 'Vercel & Netlify Founders',
icon: Trophy,
color: 'text-emerald-500',
},
{
u1: 'dhh',
u2: 'taylorotwell',
label: 'Ruby vs PHP',
icon: Star,
color: 'text-rose-500',
},
{
u1: 'jhasourav07',
u2: 'leerob',
label: 'Rising vs Vet',
icon: Swords,
color: 'text-purple-500',
},
];

export interface RivalryItem {
u1: string;
u2: string;
Expand All @@ -64,9 +18,7 @@ export interface TopRivalriesTickerProps {
rivalries?: RivalryItem[] | null;
}

export default function TopRivalriesTicker({
rivalries = MOCK_RIVALRIES,
}: TopRivalriesTickerProps = {}) {
export default function TopRivalriesTicker({ rivalries = [] }: TopRivalriesTickerProps = {}) {
const router = useRouter();

const handleRivalryClick = (u1: string, u2: string) => {
Expand Down
Loading