Skip to content

Refactor: Remove Hardcoded Mock Rivalry Data from TopRivalriesTicker - #8756

Open
tmdeveloper007 wants to merge 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:fix/8680-remove-hardcoded-mock-rivalries
Open

Refactor: Remove Hardcoded Mock Rivalry Data from TopRivalriesTicker#8756
tmdeveloper007 wants to merge 1 commit into
JhaSourav07:mainfrom
tmdeveloper007:fix/8680-remove-hardcoded-mock-rivalries

Conversation

@tmdeveloper007

Copy link
Copy Markdown
Contributor

Description

Removed the hardcoded MOCK_RIVALRIES array from components/TopRivalriesTicker.tsx. Component now defaults to empty array.

Pillar

  • Other (Bug fix, refactoring, docs)

Checklist

  • I have read the CONTRIBUTING.md file.
  • My commits follow the Conventional Commits format.

Note

Please assign this PR to the tmdeveloper007 account.

Closes #8747

@retenta-bot

retenta-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

This PR aligns with previous decisions to enhance the reliability and robustness of the TopRivalriesTicker component by removing hardcoded data. By allowing the component to handle data dynamically, we improve its error resilience and exception safety. Thank you for your contribution, and please let me know if you need any further assistance!

@retenta-bot retenta-bot Bot changed the title fix : remove hardcoded mock rivalry data from TopRivalriesTicker Refactor: Remove Hardcoded Mock Rivalry Data from TopRivalriesTicker Aug 4, 2026
@tmdeveloper007
tmdeveloper007 force-pushed the fix/8680-remove-hardcoded-mock-rivalries branch from d12f68e to e8e80e9 Compare August 5, 2026 09:53
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Aamod007 Aamod007 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:refactor Code changes that neither fix a bug nor add a feature mentor:Aamod007 labels Aug 6, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Removing the hardcoded \MOCK_RIVALRIES\ from \components/TopRivalriesTicker.tsx\ and defaulting the props to an empty array makes the component cleaner and ready for dynamic data. It prevents dummy data from flashing before the actual API call completes. Excellent refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:refactor Code changes that neither fix a bug nor add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix : remove hardcoded mock rivalry data from TopRivalriesTicker component

2 participants