Skip to content

Use a safer method for detecting negative zero #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daveorourke wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

Use a safer method for detecting negative zero #3094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ internal static object Get(decimal value)
#if NET6_0_OR_GREATER
// Number of bits scale is shifted by.
const int ScaleShift = 16;

if (value == decimal.Zero)
{
Span<int> bits = stackalloc int[4];
Expand All @@ -126,13 +126,18 @@ internal static object Get(decimal value)
private static readonly object DecimalZero = decimal.Zero;
private static readonly object DecimalZeroWithTrailingZero = 0.0m;
#endif
private static readonly long NegativeZeroBits = BitConverter.DoubleToInt64Bits(-0.0d);
private static bool IsNegativeZero(double value)
{
return BitConverter.DoubleToInt64Bits(value) == NegativeZeroBits;
}

internal static object Get(double value)
{
if (value == 0.0d)
{
// Double supports -0.0. Detection logic from https://stackoverflow.com/a/4739883/11829.
return double.IsNegativeInfinity(1.0 / value) ? DoubleNegativeZero : DoubleZero;
// Double supports -0.0. Detection logic from https://stackoverflow.com/q/4739795/8525132.
return IsNegativeZero(value) ? DoubleNegativeZero : DoubleZero;
}
if (double.IsInfinity(value))
{
Expand Down