Use a safer method for detecting negative zero - #3094
Open
daveorourke wants to merge 1 commit into
Open
Conversation
The prior method would throw a DivideByZeroException on systems where the _EM_ZERODIVIDE floating point exception was enabled. See JamesNK#2869.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2869.
The prior method would throw a DivideByZeroException on systems where the
_EM_ZERODIVIDEfloating point exception was enabled.The changes in this PR are just a safer implementation of the changes in #2777 and are covered by those same tests.
Note: I tried to add a test for #2869, but changing the
_EM_ZERODIVIDEflag with _controlfp was affecting other tests due to the changing of global state and the parallel execution of the tests. I tried several different test methods before giving up on using _controlfp. I also didn't see any other use of interop (P/Invoke) in the tests, so I wasn't sure you'd accept that anyway.Even without the additional test, I think these changes are very straightforward and would resolve the above issue, preserving all existing functionality.