Skip to content

fix(OAuthAuthenticator): Callback failure when no refresh token #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippeWeidmann merged 3 commits into from
Oct 19, 2026
Merged

fix(OAuthAuthenticator): Callback failure when no refresh token #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76ae11f
fix(OAuthAuthenticator): Callback failure when no refresh token
PhilippeWeidmann Oct 16, 2026
202a106
ci: Target correct Simulator
PhilippeWeidmann Oct 16, 2026
415d083
test: Disable writing to appgroup - Only works on iOS
PhilippeWeidmann Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
- name: Checkout
uses: actions/checkout@v6
- name: Build
run: xcodebuild -scheme InfomaniakCore build -destination "platform=iOS Simulator,name=iPhone 17 Pro,OS=latest"
run: xcodebuild -scheme InfomaniakCore build -destination "platform=iOS Simulator,name=${{ vars.LATEST_IPHONE_SIMULATOR }},OS=latest"
- name: Test
run: Scripts/prepareForTesting.sh && xcodebuild -scheme InfomaniakCore-Package test -destination "platform=iOS Simulator,name=iPhone 17 Pro,OS=latest" -enableCodeCoverage YES -resultBundlePath ResultBundle.xcresult
run: Scripts/prepareForTesting.sh && xcodebuild -scheme InfomaniakCore-Package test -destination "platform=iOS Simulator,name=${{ vars.LATEST_IPHONE_SIMULATOR }},OS=latest" -enableCodeCoverage YES -resultBundlePath ResultBundle.xcresult
- name: Convert Coverage Report
run: ./Scripts/xccov-to-generic.sh ResultBundle.xcresult > coverage.xml
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@fd88b7d7ccbaefd23d8f36f73b59db7a3d246602 #6.0.0
uses: SonarSource/sonarqube-scan-action@d209202bc7d53ff1cc128f7f907dac145c9d6ae9 #8.3.0
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

Expand Down
23 changes: 12 additions & 11 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version:5.7
// swift-tools-version:5.10
// The swift-tools-version declares the minimum version of Swift required to build this package.

import Foundation
Expand Down
5 changes: 4 additions & 1 deletion Sources/InfomaniakCore/Networking/ApiFetcher.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ open class OAuthAuthenticator: Authenticator {

public weak var refreshTokenDelegate: RefreshTokenDelegate?

public init(refreshTokenDelegate: RefreshTokenDelegate) {
public init(refreshTokenDelegate: RefreshTokenDelegate?) {
self.refreshTokenDelegate = refreshTokenDelegate
}

Expand All @@ -284,6 +284,9 @@ open class OAuthAuthenticator: Authenticator {
if let error = error as NSError?, error.domain == "invalid_grant" {
self.refreshTokenDelegate?.didFailRefreshToken(credential)
completion(.failure(error))
} else if let loginError = error as? InfomaniakLoginError,
case .noRefreshToken = loginError {
completion(.failure(loginError))
} else {
// Couldn't refresh the token, keep the old token and fetch it later. Maybe because of bad network ?
completion(.success(credential))
Expand Down
2 changes: 2 additions & 0 deletions Tests/InfomaniakCoreTests/DeviceAssociation/UTDeviceManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ struct UTDeviceManager_getOrCreateCurrentDevice {
@Test("get a userDevice from the public interface and check stability",
arguments: [Int.random(in: 1 ... 100), Int.random(in: 1 ... 100)])
func currentDevice(userId: Int) async throws {
#if os(iOS)
// GIVEN
let deviceManager = DeviceManager(appGroupIdentifier: "group.infomaniak.deviceassociation",
appMarketingVersion: "1.0.0",
Expand All @@ -226,5 +227,6 @@ struct UTDeviceManager_getOrCreateCurrentDevice {
} catch {
Issue.record("unable to fetch current device twice: \(error)")
}
#endif
}
}
Loading