Repository navigation
fix(OAuthAuthenticator): Callback failure when no refresh token - #206
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve other refresh outcomes, with no blocking issues identified.
0 open findings
What changed in this PR
Fixes OAuth refresh completion handling when no refresh token is available.
Changes:
- Returns a failure for
InfomaniakLoginError.noRefreshTokeninstead of succeeding with the old credential. - Allows initialization with a nil refresh-token delegate.
| File | Description |
|---|---|
| Sources/InfomaniakCore/Networking/ApiFetcher.swift | Propagates missing-refresh-token failures and accepts an optional delegate. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PhilippeWeidmann
force-pushed
the
fix/oauthauthenticator
branch
2 times, most recently
from
October 19, 2026 11:20
7d59c55 to
4f9453b
Compare
PhilippeWeidmann
force-pushed
the
fix/oauthauthenticator
branch
from
October 19, 2026 11:36
4f9453b to
202a106
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.