Repository navigation
feat: Multi days screens structure - #236
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped multi-day structure is coherent; identified issues are minor documentation and cleanup items.
2 open findings
What changed in this PR
Adds shared multi-day timeline scaffolding for three-day and week views while reusing the existing day-grid infrastructure.
Changes:
- Introduces shared multi-day columns, headers, grid lines, and current-time indicators.
- Connects three-day and week screens to the new structure with intentionally empty event data.
- Generalizes timeline state/default naming across day-based views.
| File | Description |
|---|---|
AGENTS.md |
Documents multi-day components. |
CalendarComponents/Foundation/.../Dimens.kt |
Removes redundant whitespace. |
CalendarComponents/Foundation/.../ComponentColors.kt |
Centralizes grid-divider color. |
CalendarComponents/Foundation/.../DateState.kt |
Uses theme opacity and adds a preview. |
CalendarComponents/Day/.../WeekPager.kt |
Builds a seven-day timeline. |
CalendarComponents/Day/.../TimelineDefaults.kt |
Generalizes timeline defaults. |
CalendarComponents/Day/.../ThreeDayPager.kt |
Builds a three-day timeline. |
CalendarComponents/Day/.../state/TimelineState.kt |
Generalizes timeline state. |
CalendarComponents/Day/.../PinchToZoom.kt |
Adopts generalized state. |
CalendarComponents/Day/.../layout/TimedEventsColumn.kt |
Adopts generalized defaults. |
CalendarComponents/Day/.../layout/ResizableEventLayout.kt |
Adopts generalized defaults. |
CalendarComponents/Day/.../layout/EventLayoutConfig.kt |
Renames divider thickness. |
CalendarComponents/Day/.../DayPager.kt |
Adopts generalized state. |
CalendarComponents/Day/.../component/TimelineGrid.kt |
Shares divider styling and state. |
CalendarComponents/Day/.../component/ResizableEventItem.kt |
Adopts generalized defaults. |
CalendarComponents/Day/.../component/MultiDayPager.kt |
Implements shared multi-day layout. |
CalendarComponents/Day/.../component/DayView.kt |
Uses generalized state and divider naming. |
CalendarComponents/Day/.../component/DayTimeline.kt |
Uses generalized state and defaults. |
CalendarComponents/Day/.../component/DayHeader.kt |
Uses generalized defaults. |
CalendarComponents/Day/.../component/DayColumnHeader.kt |
Adds per-day column headers. |
CalendarComponents/Day/.../component/CurrentTimeIndicator.kt |
Adopts generalized state. |
CalendarComponents/Day/.../component/AllDayEventsBand.kt |
Adopts generalized defaults. |
app/.../screen/week/WeekScreen.kt |
Displays the week structure. |
app/.../screen/threeDays/ThreeDayScreen.kt |
Displays the three-day structure. |
app/.../screen/day/DayScreen.kt |
Adopts generalized state. |
app/.../effects/MultiDaysScreensEffects.kt |
Removes obsolete imports. |
app/.../data/CalendarDataValues.kt |
Uses generalized defaults. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LunarX
force-pushed
the
multi-days-structure
branch
from
October 13, 2026 07:14
dd7ca67 to
6a34894
Compare
LunarX
added this pull request to stack #244
October 13, 2026 09:30
tevincent
requested changes
Oct 13, 2026
LunarX
force-pushed
the
multi-days-structure
branch
from
October 15, 2026 08:08
3db06ce to
6821b8f
Compare
tevincent
approved these changes
Oct 15, 2026
LunarX
force-pushed
the
multi-days-structure
branch
from
October 15, 2026 08:50
77df2a9 to
c708f18
Compare
…components MultiDayView lays several days side by side from the same blocks as the day view: a header, an all-day band and a timed events column per day, over the hour labels and lines, with the current time indicator in today's column. The headers, bands and columns share one column layout so they line up. ThreeDayPager and WeekPager show the days around the selected date through it, and their screens host them like DayScreen hosts DayPager. Swiping and the days' events come next. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ed outside the day view
Updated the Day component documentation to clarify its features and structure, including the handling of timed events and layout for multiple days. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
LunarX
force-pushed
the
multi-days-structure
branch
from
October 15, 2026 10:55
c708f18 to
a0878cf
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just make a basic structure that shows the grid of days, shares the code between 3/7 days views and display the correct header on top of every column.
What's still missing: