Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pager range can produce invalid pages, the loader cache is not actually shared, and the architecture map is inaccurate.
3 open findings
What changed in this PR
Centralizes event loading for day, three-day, and week views, completing the event integration started in #236.
Changes:
- Adds shared timeline state and event loader.
- Displays events and enables event-detail navigation across timeline views.
- Moves event grouping utilities and updates architecture documentation.
| File | Description |
|---|---|
DayEventGroupingExt.kt |
Moves event grouping utilities to the shared utils package. |
WeekViewModel.kt |
Exposes shared timeline events. |
WeekScreen.kt |
Displays events and handles event clicks. |
ThreeDayViewModel.kt |
Exposes shared timeline events. |
ThreeDayScreen.kt |
Displays events and handles event clicks. |
DayViewModel.kt |
Replaces local loading logic with the shared loader. |
DayScreen.kt |
Consumes the unified timeline state. |
MainNavHost.kt |
Wires event-detail navigation. |
TimelineUiState.kt |
Generalizes timeline loading state. |
DayEventsLoader.kt |
Adds centralized event observation and mapping. |
app/AGENTS.md |
Updates the application context map. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LunarX
force-pushed
the
multi-days-event-loading
branch
2 times, most recently
from
October 15, 2026 08:08
00e028b to
049c64f
Compare
LunarX
force-pushed
the
multi-days-event-loading
branch
2 times, most recently
from
October 15, 2026 08:50
990db43 to
6feca8d
Compare
LunarX
force-pushed
the
multi-days-event-loading
branch
from
October 15, 2026 10:55
6feca8d to
7bdc2d8
Compare
…hared with the day view
…no screen observes them
…empty until events load
…explicit with a shared TimelineUiState
…d between screens
Co-authored-by: LunarX <32095402+LunarX@users.noreply.github.com>
Co-authored-by: LunarX <32095402+LunarX@users.noreply.github.com>
LunarX
force-pushed
the
multi-days-event-loading
branch
from
October 15, 2026 12:28
7bdc2d8 to
a3c0078
Compare
|
This PR/issue depends on:
|
…DaysViewModel A specific view model is not needed per screen for now so instead of duplicating the logic, we can share it here
|
tevincent
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract logic used by DayViewModel to load events and reuse it for three days and week view models.
This PR also optimizes load times and RAM consumption by caching and reusing the data between the three screens.
Depends on #236