Skip to content

fix(build): expose module licenses in generated license reports#85

Closed
Ludy87 wants to merge 2 commits into
HubSpot:masterfrom
Ludy87:add_license
Closed

fix(build): expose module licenses in generated license reports#85
Ludy87 wants to merge 2 commits into
HubSpot:masterfrom
Ludy87:add_license

Conversation

@Ludy87

@Ludy87 Ludy87 commented Jul 13, 2026

Copy link
Copy Markdown

Description of Changes

Added Apache License 2.0 metadata to the Maven POM files for:

  • hubspot-style
  • hubspot-style-test
  • immutable-collection-encodings
  • immutables-exceptions

This change ensures that the modules' license is detected and displayed.

Previously, no license information was shown for these modules because their POM files did not explicitly declare a license.

Why the license metadata was not detected

com.github.jk1.dependency-license-report derives license information from the Maven metadata of each resolved dependency rather than from the repository's LICENSE file.

The affected module POMs did not contain their own <licenses> section. The Apache 2.0 license was declared only in the parent project POM. Although the plugin supports collecting licenses from parent POMs, this depends on the complete parent POM chain being resolved and interpreted correctly. For these artifacts, that inherited license did not result in usable module-level license metadata, so the modules appeared without a license in checkLicense and generateLicenseReport.

Declaring the Apache 2.0 license directly in every published module POM makes each artifact's metadata self-contained. This allows the plugin to detect the license reliably without depending on parent POM traversal.

@jhaber

jhaber commented Jul 14, 2026

Copy link
Copy Markdown
Member

This should already be fixed in newer versions, and I sent a PR to make jinjava use a newer version HubSpot/jinjava#1324

@jhaber jhaber closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants