fix(build): expose module licenses in generated license reports#85
Closed
Ludy87 wants to merge 2 commits into
Closed
fix(build): expose module licenses in generated license reports#85Ludy87 wants to merge 2 commits into
Ludy87 wants to merge 2 commits into
Conversation
Member
|
This should already be fixed in newer versions, and I sent a PR to make jinjava use a newer version HubSpot/jinjava#1324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added Apache License 2.0 metadata to the Maven POM files for:
hubspot-stylehubspot-style-testimmutable-collection-encodingsimmutables-exceptionsThis change ensures that the modules' license is detected and displayed.
Previously, no license information was shown for these modules because their POM files did not explicitly declare a license.
Why the license metadata was not detected
com.github.jk1.dependency-license-reportderives license information from the Maven metadata of each resolved dependency rather than from the repository'sLICENSEfile.The affected module POMs did not contain their own
<licenses>section. The Apache 2.0 license was declared only in the parent project POM. Although the plugin supports collecting licenses from parent POMs, this depends on the complete parent POM chain being resolved and interpreted correctly. For these artifacts, that inherited license did not result in usable module-level license metadata, so the modules appeared without a license incheckLicenseandgenerateLicenseReport.Declaring the Apache 2.0 license directly in every published module POM makes each artifact's metadata self-contained. This allows the plugin to detect the license reliably without depending on parent POM traversal.