Create-PDF engine: render from a structured document#7018
Merged
Conversation
The create-pdf tool now receives the assembled document as structured fields and builds the HTML from a fixed server-side template, instead of the engine sending pre-rendered HTML. The dispatch endpoint is also gated on the aiEngine flag.
EthanHealy01
requested review from
ConnorYoh,
Frooodle,
Ludy87 and
jbrunton96
as code owners
July 13, 2026 12:41
dosubot
Bot
added
size:XL
stirlingbot
Bot
added
Java
EthanHealy01
enabled auto-merge
July 13, 2026 13:19
dosubot
Bot
added
size:L
Collaborator
Contributor
Author
Wow. Thank you 🙏 |
Collaborator
I will build a module for us so that we are independent of such errors. |
Contributor
✅ Backend License Check PassedAll backend dependencies have valid and allowed licenses. The backend license report has been updated successfully. |
jbrunton96
approved these changes
Jul 14, 2026
ConnorYoh
approved these changes
Jul 14, 2026
ConnorYoh
left a comment
ConnorYoh
left a comment
Member
There was a problem hiding this comment.
This PR makes a decision on how we define documents for creation using the AiDocument.java model. This gives us security by design which is great but will make managing images and more complex inline styling harder.
Future followup is to pass document in as the aiDocument and let spring parse is rather than as a string and manually parse it. I think it will require a bit of fettling but will be good in the long run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.