Fix recents not refreshing on clear-all, and pending keys surviving a clear - #2696
Open
MiMoHo wants to merge 1 commit into
Open
Fix recents not refreshing on clear-all, and pending keys surviving a clear#2696MiMoHo wants to merge 1 commit into
MiMoHo wants to merge 1 commit into
Conversation
… clear On the remove_recents rework, clearRecentKeys() clears RecentEmojis and the grid but never tells the view to refresh, so long-pressing the recents tab icon leaves the now-empty grid on screen until the tab is switched. notifyItemChanged does not rebind the currently visible ViewPager2 page, so refresh the visible recents page's inner adapter directly, mirroring the tab-change path in onViewDetachedFromWindow. removeAllKeys() also cleared mGridKeys but not mPendingKeys, so an emoji typed while viewing the recents tab survived a clear-all and was re-added by the next flushPendingRecentKeys(). Clear pending keys too. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the
remove_recentsrework,clearRecentKeys()clearsRecentEmojisand the grid but never tells the view to refresh, so long-pressing the recents tab icon leaves the now-empty grid on screen until the tab is switched.notifyItemChangeddoes not rebind the currently visibleViewPager2page, so refresh the visible recents page's inner adapter directly, mirroring the tab-change path inonViewDetachedFromWindow.removeAllKeys()also clearedmGridKeysbut notmPendingKeys, so an emoji typed while viewing the recents tab survived a clear-all and was re-added by the nextflushPendingRecentKeys(). Clear pending keys too.Tested on-device.