Add ability to remove or clear recent emojis - #2603
Conversation
|
Not a maintainer, but I had a close look at the diff — the feature itself looks well scoped (nice that removal reuses the popup mechanism and that
|
In the recents category each entry represents a specific emoji the user already picked, including whatever skin tone they chose at the time. Re-opening the skin-tone variants there doesn't really make sense, since the recent entry is the historical choice |
a5543b5 to
a5bb900
Compare
|
Force-pushed to fix the commit author info on the previous push, which was wrong. No changes to the actual diffs. |
|
@RHJihan I wasn't happy with the style, in general where things were added just for this functionality, and especially the addition of a keycode that is valid but useless everywhere except in a popup in recent emoji view. I worked on a different implementation that now allows a more generic callback for popup keys: a32c560
Can you elaborate on how you tested to get this result? As @RHJihan said in recents there are no popups except for the descriptions (but those still work), so I am confused.
Is it really easy to accidentally long-press on this? And even if so, I'd say the damage is rather small. |
|
Thanks @RHJihan for the work here, and @Helium314 for the alternative. First, a correction to my earlier review — I was wrong about the skin-tone popups. Recent emojis are built with their popup keys dropped ( I prefer @Helium314's Building on that: one thing both versions still share is that "clear all" is an unconfirmed long-press on the recents tab — an invisible gesture on a navigation tab, easy to hit by accident, no undo. I put together a small change on top of Diff on top of your branch: remove_recents...MiMoHo:2603-unified-popup |
|
@Helium314, thanks a lot for taking the time to rework this and for the cleaner approach. I tested it out and it works well overall. One thing I noticed: after long-pressing the recent category icon, the emojis are actually cleared under the hood, but the view doesn't update right away, so they still show up until you switch tabs. I double checked this by trying to delete one of the "still visible" emojis afterward, and nothing happened, which confirms they were already gone. debug log: emoji.mp4 |
|
I looked into this @RHJihan. The clear does work; it's a refresh issue plus a second latent bug:
I've tested both on-device (clear-all now clears the grid immediately, and the pending emoji no longer reappears after a clear + tab switch). I opened #6 against your branch. |
|
Thanks @MiMoHo! Just to clarify, the issue is in @Helium314's implementation. |
|
You're right @RHJihan, thanks for the pointer. On the |
Adds the ability to manage the recent emoji list:
The delete button coexists with the existing "show emoji description on long-press" feature and is scoped to the recent category only.
Fixes #860
Fixes #2209
I want to be transparent that this PR was implemented mostly with Claude Code, with me guiding the process and testing the results.
If it meets the project's standards, feel free to merge it. If not, please treat it as a starting point. I'm happy for maintainers to edit, refine or rework it as needed.
I'm sharing it so the work just doesn't stay on my machine. Thanks for taking a look!