Use Tile for map cells and their accessor - #199
Conversation
Adapt the map terminology cleanup from Stéphane Magnenat’s PR #85 to the current engine and test harnesses. Preserve all string literals, including the historical cases save section. Co-authored-by: Stéphane Magnenat <stephane@magnenat.net>
Giszmo
left a comment
There was a problem hiding this comment.
Reviewed the full diff and PR head: pure identifier rename (Case→Tile, getCase→getTile, cases→tiles), +151/-151 exact wash, no leftover references, no smuggled behavior changes, save-format section-name literal ("cases") preserved for backward compat, CI green on linux 22.04/24.04 and Windows. Approving.
Non-blocking nit: test/WinningConditionsHarness.cpp had an unrelated local Case struct used for prestige test scenarios that got swept into the same mechanical rename and is now confusingly named Tile/tiles[] despite having nothing to do with map tiles. Worth a follow-up rename (e.g. PrestigeCase), not blocking this PR.
|
Merging approved head Final verification checked unchanged head, approval and successful Ubuntu 22.04, Ubuntu 24.04 and Windows CI: https://github.com/Globulation2/glob2/actions/runs/34183000870 . Giszmo independently reviewed the full diff as identifier-only renaming, preserving the serialized "cases" section literal. The PR's existing validation record also reports macOS client/server builds, 16 test executables and 60,000 ticks per version with identical replay bytes/checksums; those runs were not repeated during this merge check. No gameplay, data-layout or save-format changes are intended. The reviewer marked the unrelated prestige-test type naming nit non-blocking. |
Replace the French map-cell name
CasewithTile, renamegetCasetogetTileand the map'scasesstorage totiles, and update the editor's member pointer and current test harnesses. This is the map terminology portion of Stéphane Magnenat's #85, adapted to current master.All string literals remain unchanged, including the historical
casessave section. No data layout, algorithms, or gameplay changes are intended.Validation:
Companion PR: #200
This replaces part of #85. The complementary spelling/comment patch and Kyle's already-landed cb7856e cover the selected spelling cleanup; the original broad casing-only sweep is intentionally omitted.