Skip to content

Fix horse sprite deploy: cache-bust assets and harden paddock rendering - #23

Closed
Exios66 wants to merge 3 commits into
mainfrom
cursor/fix-horse-sprites-pages-4004
Closed

Exios66 wants to merge 3 commits into
mainfrom
cursor/fix-horse-sprites-pages-4004

Conversation

@Exios66

@Exios66 Exios66 commented Jul 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

Restores deploy-time asset cache-busting and paddock sprite hardening after merging current main (#67 refactor).

Changes vs main

  • docs/index.html — __ASSET_SHA__ query params (consumed by sync-gh-pages.sh)
  • docs/css/casino.css — min size on horse sprite canvases
  • docs/js/ui/racing-renderers.js — fallback assignHorseSprites if a horse lacks spriteId

Merge resolution

Conflicts against the extracted racing-renderers.js / app split were resolved by keeping mainline modules and re-applying the still-missing cache-bust pieces.

Open in Web Open in Cursor 

github-actions Bot and others added 2 commits July 5, 2026 07:28
Stamp index.html asset URLs with the main commit SHA during gh-pages sync so
browsers fetch fresh JS after deploys. Backfill missing horse spriteId values
in the paddock, guard canvas scale at 1+, and set minimum canvas dimensions.

Co-authored-by: Jack J Burleson // LJM <Exios66@users.noreply.github.com>
Co-authored-by: Jack J Burleson // LJM <Exios66@users.noreply.github.com>
@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Resolve conflicts against the #67 refactor by keeping mainline app/
racing modules, then re-apply deploy cache-bust placeholders and
paddock sprite-id hardening that were still missing on main.

Co-authored-by: Jack J Burleson // LJM <Exios66@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved — narrow docs frontend changes (asset cache-busting placeholders, paddock sprite backfill, canvas min dimensions) with bounded blast radius and no policy requiring human review. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

cursor Bot pushed a commit that referenced this pull request Jul 26, 2026
Port the remaining unique fixes from PR #23: stamp __ASSET_SHA__ on
terminal assets for sync-gh-pages.sh, backfill missing horse spriteIds
in the paddock, and set minimum canvas dimensions.

Co-authored-by: Jack J Burleson // LJM <Exios66@users.noreply.github.com>

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Open-PR triage: still valid, but superseded

Status: mergeable, but Checks python/web are red due to Actions billing — not because of these three file changes.

What’s still useful vs main

  • __ASSET_SHA__ placeholders in docs/index.html (consumed by scripts/sync-gh-pages.sh)
  • Paddock spriteId backfill in racing-renderers.js
  • Horse canvas min-width / min-height

Remedy

These unique bits are already re-applied on #92. Prefer merging #92 and closing this PR to avoid duplicate churn. If you keep this branch, ignore the failing Checks jobs until billing is restored (or run uv run pytest -q locally).

Open in Web View Automation 

Sent by Cursor Automation: PR Analysis

Comment thread docs/index.html
Comment thread docs/js/ui/racing-renderers.js

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Daily open-PR triage (2026-07-26)

Status: superseded + merge-conflicting — do not merge; close instead

GitHub reports CONFLICTING merge state. A three-way merge against current main conflicts in docs/index.html (arcade overlay vs. stale branch), docs/css/casino.css, and docs/js/ui/racing-renderers.js.

More importantly, merging this branch would revert major main features (cabinet boot screen, arcade CRT overlay, playing-card sprites, trading-floor ticker, etc.) while only adding ~16 lines of horse/cache-bust hardening — those fixes are already on main via #92:

  • docs/index.html — __ASSET_SHA__ query params on CSS + app.js
  • docs/css/casino.css — .horse-sprite-canvas { min-width: 48px; min-height: 36px; }
  • docs/js/ui/racing-renderers.js — withHorseSpriteIds() backfill before paddock render

Checks on current main: pytest + RPG smoke pass.

Recommended action: close this PR as superseded by #92. If you still want a fresh branch for audit trail, cherry-pick only the three files above onto current main — but there is nothing left to cherry-pick today.

Open in Web View Automation 

Sent by Cursor Automation: PR Analysis

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daily open-PR triage (2026-07-26)

Status: CONFLICTING and harmful to merge — close instead of resolving conflicts

GitHub reports CONFLICTING / dirty. Resolving conflicts on this branch would not be a safe fix — a three-way merge would revert major main features while adding only ~16 lines of horse/cache-bust hardening that are already on main via #92:

File Already on main
docs/index.html __ASSET_SHA__ query params
docs/css/casino.css .horse-sprite-canvas { min-width: 48px; min-height: 36px; }
docs/js/ui/racing-renderers.js withHorseSpriteIds() backfill

Conflicts specifically involve removing #arcade-overlay, cabinet boot screen, playing-card sprites, and trading-floor ticker CSS — all post-#92 main work (#94, #91, #108, #110).

No fix PR opened — there is nothing left to cherry-pick; opening another branch would duplicate #92.

Recommended action: close as superseded by #92.

Open in Web View Automation 

Sent by Cursor Automation: PR Analysis

@Exios66 Exios66 closed this Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants