-
Notifications
You must be signed in to change notification settings - Fork 21
Wire up Sl_ddvel (gas dry-dep coupling) and cam_in%dstflx (Fall_flxdst) to CMEPS via nuopc #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimmielin
wants to merge
5
commits into
ESCOMP:development
Choose a base branch
from
jimmielin:hplin/sl-ddvel-coupler
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
123992b
Wire up sl_ddvel from CMEPS (for gas drydep) via nuopc
hplin-ucar 5f7e065
Wire up Fall_flxdst (dust emission fluxes from land) from CMEPS via n…
88f738d
Mirror drydep_list names into drydep_coupling; depvel units are cm/s.
52f811e
Update comments
19da0f4
Merge branch 'development' into hplin/sl-ddvel-coupler
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| module drydep_coupling | ||
|
|
||
| implicit none | ||
| private | ||
|
|
||
| public :: drydep_coupling_set_nflds | ||
| public :: drydep_coupling_set_list | ||
|
|
||
| !> \section arg_table_drydep_coupling Argument Table | ||
| !! \htmlinclude drydep_coupling.html | ||
| ! Number of gas species with land-computed dry deposition velocities | ||
| ! received through the coupler field Sl_ddvel. The authoritative value | ||
| ! is owned by shr_drydep_mod (CMEPS) and set by shr_drydep_readnl during | ||
| ! the NUOPC advertise phase; the cap mirrors it here, before physics | ||
| ! initialization allocates registry fields dimensioned by it. | ||
| integer, public, protected :: n_drydep = 0 | ||
|
|
||
| ! Species names of the drv_flds_in drydep_list, in list order. The list | ||
| ! order is the Sl_ddvel coupler index contract with the land model, so | ||
| ! it cannot be reordered or trimmed atm-side. Mirrored by the cap along | ||
| ! with the count; consumed by gas_drydep_ccpp at init (no metadata | ||
| ! entry: character arrays are use-associated, not capgen-passed). | ||
| character(len=32), allocatable, public, protected :: drydep_list(:) | ||
|
|
||
| contains | ||
|
|
||
| subroutine drydep_coupling_set_nflds(n_drydep_in) | ||
| integer, intent(in) :: n_drydep_in | ||
|
|
||
| n_drydep = n_drydep_in | ||
| end subroutine drydep_coupling_set_nflds | ||
|
|
||
| subroutine drydep_coupling_set_list(drydep_list_in) | ||
| character(len=*), intent(in) :: drydep_list_in(:) | ||
|
|
||
| drydep_list = drydep_list_in | ||
| end subroutine drydep_coupling_set_list | ||
|
|
||
| end module drydep_coupling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| [ccpp-table-properties] | ||
| name = drydep_coupling | ||
| type = module | ||
|
|
||
| [ccpp-arg-table] | ||
| name = drydep_coupling | ||
| type = module | ||
| [ n_drydep ] | ||
| standard_name = number_of_dry_deposition_species | ||
| units = count | ||
| type = integer | ||
| dimensions = () | ||
| protected = True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.