Skip to content

Wire up Sl_ddvel (gas dry-dep coupling) and cam_in%dstflx (Fall_flxdst) to CMEPS via nuopc - #523

Open
jimmielin wants to merge 5 commits into
ESCOMP:developmentfrom
jimmielin:hplin/sl-ddvel-coupler
Open

Wire up Sl_ddvel (gas dry-dep coupling) and cam_in%dstflx (Fall_flxdst) to CMEPS via nuopc#523
jimmielin wants to merge 5 commits into
ESCOMP:developmentfrom
jimmielin:hplin/sl-ddvel-coupler

Conversation

@jimmielin

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):
Originator(s): @jimmielin
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What: claude-fable:5
How: scoped the NUOPC/CMEPS path and the CAM infrastructure.

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

Describe any changes made to build system:

Describe any changes made to the namelist:

List any changes to the defaults for the input datasets (e.g. boundary datasets):

List all files eliminated and why:

List all files added and what they do:

M       src/cpl/nuopc/atm_import_export.F90
  - wire up Sl_ddvel, Fall_flxdst

M       src/data/registry.xml
  - fix dust dimensions in cam_in%dstflx
  - adds dust dimensions with a note that this is not configurable without a coordinated overhaul of the dust infrastructure coordinated with everyone else.

A       src/physics/utils/drydep_coupling.F90
A       src/physics/utils/drydep_coupling.meta
  - used to mirror NUOPC cap drydep_nflds for providing to physics schemes.
  - this must be in a separate module via a setter because simple re-export via USE is not accepted by capgen.

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

hplin-ucar and others added 2 commits July 13, 2026 16:49
…uopc

Move the Fall_flxdst import out of the disabled (#if 0) optional-fields
block, following the Sl_ddvel pattern: the field was already advertised
(ungridded bounds 1:4, set_active_Fall_flxdst1), only the import copy was
disabled. The registry dstflx placeholder gains its bin dimension,
dust_size_bin_dimension (a registry-declared parameter = 4; the four-bin
assumption is a fixed structural contract with the land model, see
dstdry1-4/dstwet1-4), so the generated cam_in%dstflx matches the cap's
2-D copy (with med2mod_areacor, as this is a flux). The block's 'dry
deposition fluxes' comment was corrected to dust emission fluxes.
@nusbaume
nusbaume requested a review from cacraigucar July 15, 2026 16:14
- drydep_coupling: add the drv_flds_in drydep_list species names next to
  the existing count mirror (set by the cap after shr_drydep_readnl,
  before physics init). The list order is the Sl_ddvel coupler index
  contract with the land model. Names are use-associated by the
  gas_drydep_ccpp scheme at init; no metadata entry (character arrays
  are not capgen-passed).
- registry: correct the depvel units attribute to cm s-1. CLM computes
  and sends Sl_ddvel in cm/s and CAM's mo_drydep consumes it as-is in
  the Wesely land-type merge (the 1e-2 in its flux expression is the
  cm/s to m/s conversion); a consumer metadata entry declaring cm s-1
  against an m s-1 registry attribute would otherwise invite a spurious
  capgen unit conversion. The sl-ddvel coupler PR carries the same
  attribute and should pick up this fix.

(cherry picked from commit 418b95b4b1e3b9e725cbe324453bd103b240ad31)
Comment thread src/data/registry.xml
@jimmielin
jimmielin requested a review from nusbaume July 22, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants