Wire up Sl_ddvel (gas dry-dep coupling) and cam_in%dstflx (Fall_flxdst) to CMEPS via nuopc - #523
Open
jimmielin wants to merge 5 commits into
Open
Wire up Sl_ddvel (gas dry-dep coupling) and cam_in%dstflx (Fall_flxdst) to CMEPS via nuopc#523jimmielin wants to merge 5 commits into
jimmielin wants to merge 5 commits into
Conversation
…uopc Move the Fall_flxdst import out of the disabled (#if 0) optional-fields block, following the Sl_ddvel pattern: the field was already advertised (ungridded bounds 1:4, set_active_Fall_flxdst1), only the import copy was disabled. The registry dstflx placeholder gains its bin dimension, dust_size_bin_dimension (a registry-declared parameter = 4; the four-bin assumption is a fixed structural contract with the land model, see dstdry1-4/dstwet1-4), so the generated cam_in%dstflx matches the cap's 2-D copy (with med2mod_areacor, as this is a flux). The block's 'dry deposition fluxes' comment was corrected to dust emission fluxes.
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
July 13, 2026 21:01 — with
GitHub Actions
Error
- drydep_coupling: add the drv_flds_in drydep_list species names next to the existing count mirror (set by the cap after shr_drydep_readnl, before physics init). The list order is the Sl_ddvel coupler index contract with the land model. Names are use-associated by the gas_drydep_ccpp scheme at init; no metadata entry (character arrays are not capgen-passed). - registry: correct the depvel units attribute to cm s-1. CLM computes and sends Sl_ddvel in cm/s and CAM's mo_drydep consumes it as-is in the Wesely land-type merge (the 1e-2 in its flux expression is the cm/s to m/s conversion); a consumer metadata entry declaring cm s-1 against an m s-1 registry attribute would otherwise invite a spurious capgen unit conversion. The sl-ddvel coupler PR carries the same attribute and should pick up this fix. (cherry picked from commit 418b95b4b1e3b9e725cbe324453bd103b240ad31)
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
July 22, 2026 16:22 — with
GitHub Actions
Error
cacraigucar
approved these changes
Jul 22, 2026
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
July 22, 2026 20:40 — with
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What: claude-fable:5
How: scoped the NUOPC/CMEPS path and the CAM infrastructure.
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Sl_ddveldry deposition velocity via the coupler for gas-phase dry deposition.Fall_flxdstfield intocam_in%dstflx. Fixes the wrong dimensions (missing indexed 4 dimension). Requires CAM side fix: part of cam6_4_192: Add snapshot support for FRACIS, cam_in_dstflx, which have constituent or other dimensions CAM#1610 and CAM-SIMA side fix to read this field: Constituent- and index-dimensioned fields for read and check physics data #521Describe any changes made to build system:
Describe any changes made to the namelist:
List any changes to the defaults for the input datasets (e.g. boundary datasets):
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: