Skip to content

fix: hermes test hardcoding python3 (fails on Windows) #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhedhialy wants to merge 1 commit into from
+14 −1
Closed

fix: hermes test hardcoding python3 (fails on Windows) #697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/hermes-plugin.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,21 @@ const skillCommands = commands.filter((name) => name !== 'ponytail');

const root = path.join(__dirname, '..');

// ponytail: probe once; on Windows `python3` is the Store-alias stub that fails
// even when Python is installed, so fall back to `python` (mirrors benchmarks/correctness.js).
let pythonCmd;
function pythonExe() {
if (pythonCmd) return pythonCmd;
for (const cmd of ['python3', 'python']) {
if (spawnSync(cmd, ['-c', 'import sys'], { encoding: 'utf8' }).status === 0) {
return (pythonCmd = cmd);
}
}
return (pythonCmd = 'python3');
}

function python(script, env = {}) {
const result = spawnSync('python3', ['-c', script], {
const result = spawnSync(pythonExe(), ['-c', script], {
cwd: root,
env: { ...process.env, ...env },
encoding: 'utf8',
Expand Down
Loading