fix: hermes test hardcoding python3 (fails on Windows) - #697
Closed
dhedhialy wants to merge 1 commit into
Closed
Conversation
tests/hermes-plugin.test.js spawned python3 with no fallback. On Windows python3 is the Store app-execution-alias stub that exits non-zero even when Python is installed. Reuse the probe/fallback pattern from benchmarks/correctness.js: try python3, fall back to python, cache the result. Fixes DietrichGebert#498
Owner
|
Thanks! This exact fix already went in via #513, so main has the python3 probe. Closing as already done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Python-3 lookup in the hermes test so it passes on Windows (where 'python3' is not always on PATH).