Skip to content

CMP-4605: Guard kubevirt NAD rules against NADs without a spec #15020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vincent056 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CMP-4605: Guard kubevirt NAD rules against NADs without a spec #15020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f400ec
CMP-4605: Guard kubevirt NAD rules against NADs without a spec
Vincent056 Aug 19, 2026
d32be12
Also guard against empty-string NAD config
Vincent056 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions applications/openshift-virtualization/kubevirt-bridge-mac-spoof-filtering/cel/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ inputs:

expression: |
nads.items.all(n,
!has(n.spec) ||
!has(n.spec.config) ||
n.spec.config == "" ||
!("type" in parseJSON(n.spec.config)) ||
parseJSON(n.spec.config).type != "bridge" ||
("macspoofchk" in parseJSON(n.spec.config) && parseJSON(n.spec.config).macspoofchk == true)
Expand Down
26 changes: 26 additions & 0 deletions ...cations/openshift-virtualization/kubevirt-bridge-mac-spoof-filtering/cel/tests/cases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,29 @@ cases:
spec:
config: '{"cniVersion": "0.3.1", "type": "bridge", "bridge": "br3",
"macspoofchk": false}'
- name: NAD with no spec at all is compliant (regression - istio-cni style)
expect: true
inputs:
nads:
apiVersion: v1
kind: List
items:
- apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
name: istio-cni
namespace: default
- name: NAD with an empty-string config is compliant (regression - parseJSON(""))
expect: true
inputs:
nads:
apiVersion: v1
kind: List
items:
- apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
name: empty-config
namespace: default
spec:
config: ""
2 changes: 2 additions & 0 deletions applications/openshift-virtualization/kubevirt-localnet-vlan-required/cel/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ inputs:

expression: |
nads.items.all(n,
!has(n.spec) ||
!has(n.spec.config) ||
n.spec.config == "" ||
!("topology" in parseJSON(n.spec.config)) ||
parseJSON(n.spec.config).topology != "localnet" ||
("vlanID" in parseJSON(n.spec.config) && parseJSON(n.spec.config).vlanID > 0)
Expand Down
26 changes: 26 additions & 0 deletions applications/openshift-virtualization/kubevirt-localnet-vlan-required/cel/tests/cases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,29 @@ cases:
spec:
config: '{"cniVersion": "0.3.1", "type": "ovn-k8s-cni-overlay", "topology":
"localnet", "netAttachDefName": "default/localnet-untagged"}'
- name: NAD with no spec at all is compliant (regression - istio-cni style)
expect: true
inputs:
nads:
apiVersion: v1
kind: List
items:
- apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
name: istio-cni
namespace: default
- name: NAD with an empty-string config is compliant (regression - parseJSON(""))
expect: true
inputs:
nads:
apiVersion: v1
kind: List
items:
- apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
name: empty-config
namespace: default
spec:
config: ""
Loading