CMP-4605: Guard kubevirt NAD rules against NADs without a spec - #15020
Open
Vincent056 wants to merge 1 commit into
Open
CMP-4605: Guard kubevirt NAD rules against NADs without a spec#15020Vincent056 wants to merge 1 commit into
Vincent056 wants to merge 1 commit into
Conversation
kubevirt-localnet-vlan-required and kubevirt-bridge-mac-spoof-filtering guarded only has(n.spec.config). A NetworkAttachmentDefinition with no spec at all is legitimate (e.g. the istio-cni NAD), but it makes has(n.spec.config) raise 'no such key: spec' at evaluation time, and the scanner maps missing-key errors to FAIL - so both rules false-FAIL on any cluster carrying such a NAD. Prepend !has(n.spec) to both expressions and add a spec-less NAD regression fixture: it fails 5/6 and 6/7 against the unfixed expressions and all cases pass with the fix (celctl, the operator's scanner engine). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kubevirt-localnet-vlan-requiredandkubevirt-bridge-mac-spoof-filteringguard onlyhas(n.spec.config). A NetworkAttachmentDefinition with nospecat all is legitimate (e.g. theistio-cniNAD), but it makeshas(n.spec.config)raiseno such key: specat evaluation time — and the scanner maps missing-key errors to FAIL, so both rules false-FAIL on any cluster carrying such a NAD. Observed during CIS OCP-Virt profile validation on a 4.22 + Virtualization cluster.Fix
Prepend
!has(n.spec) ||to both expressions, and add a spec-less NAD regression fixture to bothcel/tests/cases.yaml.Testing
Via
celctl(the Compliance Operator's scanner engine): the new fixture fails against the unfixed expressions (5/6 and 6/7 cases) and 6/6 / 7/7 cases pass with the fix.🤖 Generated with Claude Code