CMP-4464: Add fmt-check target to gate CI on Go formatting - #1300
Conversation
|
@rhmdnd: This pull request references CMP-4464 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
#1292 needs to land to fix current gofmt drift before this will pass. |
Add a fmt-check target that fails if any Go source files need formatting. The build, run, test-unit, and test-coverage targets now depend on fmt-check instead of fmt, so CI rejects unformatted code. The existing fmt target is unchanged so contributors can still auto-fix formatting with make fmt. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6c98d14 to
7456eb8
Compare
|
@taimurhafeez thanks for the reviews here. I needed to rebase so CI passes now that the gofmt changes are in. |
|
🤖 To deploy this PR, run the following command: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, taimurhafeez, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks like tests are failing because the test coverage went down - do we wanna have the test coverage ignore specific files? Or should we add some unit tests? |
|
Stale PRs are closed after 21d of inactivity. If this PR is still relevant, comment to refresh it or remove the stale label. If this PR is safe to close now please do so with /lifecycle stale |
5 participants
Add a fmt-check target that fails if any Go source files need
formatting. The build, run, test-unit, and test-coverage targets
now depend on fmt-check instead of fmt, so CI rejects unformatted
code. The existing fmt target is unchanged so contributors can
still auto-fix formatting with make fmt.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com