Skip to content

CMP-4464: Run go fmt across the codebase - #1292

Merged
rhmdnd merged 1 commit into
ComplianceAsCode:masterfrom
rhmdnd:fix/gofmt-whitespace
Jul 13, 2026
Merged

CMP-4464: Run go fmt across the codebase#1292
rhmdnd merged 1 commit into
ComplianceAsCode:masterfrom
rhmdnd:fix/gofmt-whitespace

Conversation

@rhmdnd

@rhmdnd rhmdnd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Several files had accumulated whitespace and formatting drift.
This commit applies go fmt ./... to bring them back in line.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

@openshift-ci
openshift-ci Bot requested review from Vincent056 and mrogers950 July 1, 2026 13:06
@openshift-ci openshift-ci Bot added the approved label Jul 1, 2026
@rhmdnd rhmdnd changed the title Run go fmt across the codebase CMP-4453: Run go fmt across the codebase Jul 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Collaborator

@rhmdnd: This pull request references CMP-4453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Several files had accumulated whitespace and formatting drift.
This commit applies go fmt ./... to bring them back in line.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhmdnd
rhmdnd requested review from taimurhafeez and removed request for mrogers950 July 1, 2026 13:09
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1292-3c9be62a9e2dddc567a2770d1647e09afb59a28d

@taimurhafeez

Copy link
Copy Markdown
Collaborator

Several files had accumulated whitespace and formatting drift. This commit applies go fmt ./... to bring them back in line.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Wouldn't be nice if we can have a hook (fmt) in Claude for post changes but before commit/pushing? Or would you prefer to do such changes separately once in a while?

@rhmdnd

rhmdnd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

Several files had accumulated whitespace and formatting drift. This commit applies go fmt ./... to bring them back in line.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Wouldn't be nice if we can have a hook (fmt) in Claude for post changes but before commit/pushing? Or would you prefer to do such changes separately once in a while?

Yes - absolutely. We could just check if the git tree is clean after running make fmt and if it isn't, we fail. That should get picked up an enforced in existing unit test jobs today.

I think we can do that in a follow on though.

@rhmdnd rhmdnd changed the title CMP-4453: Run go fmt across the codebase CMP-4464: Run go fmt across the codebase Jul 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Collaborator

@rhmdnd: This pull request references CMP-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Several files had accumulated whitespace and formatting drift.
This commit applies go fmt ./... to bring them back in line.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

taimurhafeez
taimurhafeez previously approved these changes Jul 3, 2026
Several files had accumulated whitespace and formatting drift.
This commit applies `go fmt ./...` to bring them back in line.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1292-8658c0ece750bdba663ca4d0e9bbb48f7677778b

@rhmdnd

rhmdnd commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

After this change lands we can merge #1300 to prevent drift in the future.

@taimurhafeez

Copy link
Copy Markdown
Collaborator

/test e2e-aws-parallel

@openshift-ci openshift-ci Bot added the lgtm label Jul 10, 2026
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, taimurhafeez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [rhmdnd,taimurhafeez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
rhmdnd merged commit a7d5439 into ComplianceAsCode:master Jul 13, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants