-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync upstream PR #8478 - fix(http): support binary request bodies #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: plus
Are you sure you want to change the base?
Changes from all commits
23ad7f8
b2d7719
76ff70e
b7e167b
de1e506
731a82e
bc74536
93c72de
e456de0
5bfdb1d
fd4488a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -164,13 +164,18 @@ private Insets calcSafeAreaInsets(WindowInsetsCompat insets) { | |
| } | ||
|
|
||
| private void initSafeAreaCSSVariables() { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM && insetHandlingEnabled) { | ||
| WindowInsetsCompat insets; | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) { | ||
| View v = (View) this.getBridge().getWebView().getParent(); | ||
| WindowInsetsCompat insets = ViewCompat.getRootWindowInsets(v); | ||
| if (insets != null) { | ||
| Insets safeAreaInsets = calcSafeAreaInsets(insets); | ||
| injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left); | ||
| } | ||
| insets = ViewCompat.getRootWindowInsets(v); | ||
| } else { | ||
| insets = WindowInsetsCompat.CONSUMED; | ||
| } | ||
|
|
||
| if (insets != null) { | ||
| Insets safeAreaInsets = calcSafeAreaInsets(insets); | ||
| injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left); | ||
|
Comment on lines
+167
to
+178
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Preserve The unconditional injections bypass Also applies to: 194-195, 227-228 🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
|
|
||
|
|
@@ -186,10 +191,8 @@ private void initWindowInsetsListener() { | |
| // We need to correct for a possible shown IME | ||
| v.setPadding(0, 0, 0, keyboardVisible ? imeInsets.bottom : 0); | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM && hasViewportCover && insetHandlingEnabled) { | ||
| Insets safeAreaInsets = calcSafeAreaInsets(insets); | ||
| injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left); | ||
| } | ||
| Insets safeAreaInsets = calcSafeAreaInsets(insets); | ||
| injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left); | ||
|
|
||
| return new WindowInsetsCompat.Builder(insets) | ||
| .setInsets( | ||
|
|
@@ -221,10 +224,8 @@ private void initWindowInsetsListener() { | |
| .setInsets(WindowInsetsCompat.Type.systemBars() | WindowInsetsCompat.Type.displayCutout(), Insets.of(0, 0, 0, 0)) | ||
| .build(); | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM && hasViewportCover && insetHandlingEnabled) { | ||
| Insets safeAreaInsets = calcSafeAreaInsets(newInsets); | ||
| injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left); | ||
| } | ||
| Insets safeAreaInsets = calcSafeAreaInsets(newInsets); | ||
| injectSafeAreaCSS(safeAreaInsets.top, safeAreaInsets.right, safeAreaInsets.bottom, safeAreaInsets.left); | ||
|
|
||
| return newInsets; | ||
| }); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "name": "@capacitor-plus/android", | ||
| "name": "@capacitor/android", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Update package-scope consumers with this rename. Line [2] changes the public package identity to Proposed synchronization fix-const CORE_DEPENDENTS = ['`@capacitor-plus/android`', '`@capacitor-plus/ios`'];
+const CORE_DEPENDENTS = ['`@capacitor/android`', '`@capacitor/ios`'];
-const corePkg = pkgs.find((p) => p.name === '`@capacitor-plus/core`');
+const corePkg = pkgs.find((p) => p.name === '`@capacitor/core`');
-await setPackageJsonDependencies(p, { '`@capacitor-plus/core`': range }, 'peerDependencies');
+await setPackageJsonDependencies(p, { '`@capacitor/core`': range }, 'peerDependencies');🤖 Prompt for AI Agents |
||
| "version": "8.3.4", | ||
| "description": "Capacitor+: Enhanced Capacitor with automated upstream sync - Cross-platform apps with JavaScript and the web", | ||
| "homepage": "https://capgo.app/docs/plugins/capacitor-plus/", | ||
| "author": "Capgo Team <support@capgo.app> (https://capgo.app)", | ||
| "description": "Capacitor: Cross-platform apps with JavaScript and the web", | ||
| "homepage": "https://capacitorjs.com", | ||
| "author": "Ionic Team <hi@ionic.io> (https://ionic.io)", | ||
| "license": "MIT", | ||
| "repository": { | ||
| "type": "git", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Do not manually edit the generated root changelog.
These changes should be produced by the CI/CD release process rather than committed as hand-authored edits. Revert the direct
CHANGELOG.mdchanges and regenerate them through the prescribed pipeline.🤖 Prompt for AI Agents
Source: Path instructions