chore: sync upstream PR #8478 - fix(http): support binary request bodies

[riderx]

Merge Conflict Review Required

The sync of upstream PR ionic-team#8478 from @iamanaws encountered merge conflicts.

Original PR: ionic-team#8478

What happened

• Git applied the upstream-preferred merge strategy
• This PR requires CI and manual review before merging

---

Synced from upstream by Capacitor+ Bot

Summary by CodeRabbit

• New Features

  • Added binary HTTP request and response support for files, blobs, buffers, and typed arrays across Android and iOS.
  • Added support for reading decimal configuration values in plugins.
  • Improved safe-area CSS variable handling on newer Android versions.

• Bug Fixes

  • Fixed iOS plugin asset handling for Swift Package Manager projects.
  • Improved binary response handling and empty-response behavior in fetch.

• Documentation

  • Documented the new binary HTTP data type.

[riderx]

Git applied the upstream-preferred strategy to resolve this sync. Please review the branch carefully before merging.

[github-actions]

Beta npm build

Maintainers can publish one Capacitor Plus workspace package from this PR to npm for fast testing.

Comment /publish-beta <package> after the PR checks are green.

Examples:

/publish-beta core
/publish-beta cli
/publish-beta @capacitor-plus/core

If exactly one workspace package changed, /publish-beta without a package will use that package.

Packages:

• core (@capacitor-plus/core)
• cli (@capacitor-plus/cli)
• android (@capacitor-plus/android)
• ios (@capacitor-plus/ios)

The workflow will:

• publish a prerelease package on the beta tag
• add a pinned pr-87 dist-tag for the selected package
• update this comment with the install command

Security note: beta publish is only enabled for branches inside this repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes restore official Capacitor package metadata, extend binary HTTP request and response handling across platforms, add double configuration accessors, adjust Android safe-area behavior, update CLI runtime behavior, and refresh 8.3.x changelogs.

Changes

Capacitor platform updates

Layer / File(s)	Summary
Binary HTTP bridge flow core/native-bridge.ts, android/.../native-bridge.js, ios/.../native-bridge.js, core/src/core-plugins.ts, core/src/tests/bridge.spec.ts, core/http.md	Binary request bodies are serialized as base64 with dataType: 'binary', native responses use arraybuffer, and bridge tests cover Blob, ArrayBuffer, and binary response handling.
Native binary request decoding android/.../CapacitorHttpUrlConnection.java, ios/.../CapacitorUrlRequest.swift	Android centralizes base64 decoding for file and binary requests, while iOS accepts both request types.
Platform configuration and inset behavior android/.../PluginConfig.java, android/.../JSONUtils.java, android/.../SystemBars.java, ios/.../PluginConfig.swift, android/.../MockCordovaWebViewImpl.java	Double configuration accessors are added, safe-area CSS injection is broadened, and the Cordova mock bridge formatting is updated without changing behavior.
CLI runtime behavior cli/src/ios/update.ts, cli/src/ipc.ts	Plugin package skipping is limited to SPM flows, and telemetry uses a new endpoint with HTTP 202 success handling.
Package identity and release notes */package.json, CHANGELOG.md, android/CHANGELOG.md, cli/CHANGELOG.md, core/CHANGELOG.md, ios/CHANGELOG.md	Package metadata returns to official Capacitor names and branding, while 8.3.x changelog sections and compare links are refreshed.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Fetch
  participant nativeBridge as native-bridge
  participant CapacitorHttp
  participant Response
  Fetch->>nativeBridge: serialize Blob or ArrayBuffer as binary
  nativeBridge->>CapacitorHttp: send base64 request dataType binary
  CapacitorHttp-->>nativeBridge: return arraybuffer response
  nativeBridge->>Response: decode base64 into ArrayBuffer

Loading

Suggested reviewers: jcesarmobile

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 27.78% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly highlights the main change: syncing upstream work to add binary HTTP request body support.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages.

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Risk: medium. Not approving: this cross-platform HTTP binary-body sync exceeds the low-risk threshold, and the lint check failed (frozen lockfile mismatch). Cursor Bugbot was not present on this PR. Reviewers assigned for human review.

  

_{Sent by Cursor Approval Agent: Pull Request Approver External}

[cursor]

Risk: medium. Cursor Bugbot did not run on this PR; CI lint failed (frozen lockfile mismatch), so downstream tests were skipped. Human review is needed before merge; no reviewers were assigned (none available beyond the author).

  

_{Sent by Cursor Approval Agent: Pull Request Approver}

[coderabbitai]

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

ios/Capacitor/Capacitor/Plugins/CapacitorUrlRequest.swift (1)

174-179: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Malformed base64 silently drops the request body instead of failing.

Data(base64Encoded: stringData) returns nil for invalid base64 rather than throwing, and setRequestBody assigns that directly to request.httpBody. A malformed/truncated base64 payload for a "file"/"binary" body would silently send the request with no body rather than surfacing an error. This pattern pre-dates this PR for "file", but is now reachable more often since "binary" applies to the more common Blob/ArrayBuffer/TypedArray inputs.

🛡️ Proposed fix: throw on decode failure instead of returning nil

         if dataType == "file" || dataType == "binary" {
             guard let stringData = body as? String else {
                 throw CapacitorUrlRequestError.serializationError("[ data ] argument could not be parsed as string")
             }
-            return Data(base64Encoded: stringData)
+            guard let decoded = Data(base64Encoded: stringData) else {
+                throw CapacitorUrlRequestError.serializationError("[ data ] argument could not be decoded as base64 for dataType [ \(dataType!) ]")
+            }
+            return decoded
         } else if dataType == "formData" {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ios/Capacitor/Capacitor/Plugins/CapacitorUrlRequest.swift` around lines 174 -
179, Update getRequestData for "file" and "binary" payloads to validate the
result of Data(base64Encoded: stringData) and throw
CapacitorUrlRequestError.serializationError when decoding fails, rather than
returning nil and allowing setRequestBody to send a request without a body.

android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java (1)

191-211: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Check bodyType before Content-Type

bodyType == "file"/"binary" should take precedence here. A Blob/ArrayBuffer/TypedArray request with Content-Type: application/json will hit the JSON branch and send the base64 payload as text instead of decoded bytes. Match the iOS ordering by handling binary bodies first.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java`
around lines 191 - 211, The setRequestBody method currently checks Content-Type
before bodyType, causing file or binary payloads with application/json to be
serialized as text. Reorder the branches so bodyType values "file" or "binary"
are handled first via decodeBase64RequestBody, then retain the existing
Content-Type validation and JSON handling for non-binary bodies.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@android/capacitor/src/main/java/com/getcapacitor/plugin/SystemBars.java`:
- Around line 167-178: The safe-area CSS injections in SystemBars must respect
insetHandlingEnabled. Update the injection paths around
calcSafeAreaInsets/injectSafeAreaCSS, including the additional locations at the
referenced paths, to guard all three calls with the flag so insetsHandling:
"disable" neither injects nor updates safe-area values.

In `@android/package.json`:
- Line 2: Update the package-scope matching and core-package resolution in
sync-peer-dependencies so the renamed `@capacitor/android` package is recognized
alongside the existing package scope. Ensure release preparation derives a
defined corePkg for the new scope and preserves synchronization for any
remaining `@capacitor-plus` packages.

In `@CHANGELOG.md`:
- Around line 6-30: Revert the hand-authored changes to the generated root
CHANGELOG.md, including the added 8.3.4 and 8.3.3 entries, and leave changelog
updates to the prescribed CI/CD release process.

In `@core/CHANGELOG.md`:
- Around line 6-16: Revert the manually added 8.3.x entries in core/CHANGELOG.md
lines 6-16 and regenerate the core changelog through CI/CD. Apply the same
change to ios/CHANGELOG.md lines 6-16; both changelogs must remain CI/CD-managed
artifacts and must not be edited directly.

In `@core/native-bridge.ts`:
- Around line 96-127: Resolve the unreachable Uint8Array handling in the
body-encoding branch: move the Uint8Array check before ArrayBuffer.isView(body)
if raw Uint8Array bodies must honor contentType; otherwise remove the dead
Uint8Array path. Apply the same change to core/native-bridge.ts,
android/capacitor/src/main/assets/native-bridge.js, and
ios/Capacitor/Capacitor/assets/native-bridge.js, regenerating the platform
assets when removing the path.

---

Outside diff comments:
In
`@android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java`:
- Around line 191-211: The setRequestBody method currently checks Content-Type
before bodyType, causing file or binary payloads with application/json to be
serialized as text. Reorder the branches so bodyType values "file" or "binary"
are handled first via decodeBase64RequestBody, then retain the existing
Content-Type validation and JSON handling for non-binary bodies.

In `@ios/Capacitor/Capacitor/Plugins/CapacitorUrlRequest.swift`:
- Around line 174-179: Update getRequestData for "file" and "binary" payloads to
validate the result of Data(base64Encoded: stringData) and throw
CapacitorUrlRequestError.serializationError when decoding fails, rather than
returning nil and allowing setRequestBody to send a request without a body.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b50700e9-b368-4cd7-95b4-feae7b095223

📥 Commits

Reviewing files that changed from the base of the PR and between 63026cc and fd4488a.

📒 Files selected for processing (24)

• CHANGELOG.md
• android/CHANGELOG.md
• android/capacitor/src/main/assets/native-bridge.js
• android/capacitor/src/main/java/com/getcapacitor/PluginConfig.java
• android/capacitor/src/main/java/com/getcapacitor/cordova/MockCordovaWebViewImpl.java
• android/capacitor/src/main/java/com/getcapacitor/plugin/SystemBars.java
• android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java
• android/capacitor/src/main/java/com/getcapacitor/util/JSONUtils.java
• android/package.json
• cli/CHANGELOG.md
• cli/package.json
• cli/src/ios/update.ts
• cli/src/ipc.ts
• core/CHANGELOG.md
• core/http.md
• core/native-bridge.ts
• core/package.json
• core/src/core-plugins.ts
• core/src/tests/bridge.spec.ts
• ios/CHANGELOG.md
• ios/Capacitor/Capacitor/PluginConfig.swift
• ios/Capacitor/Capacitor/Plugins/CapacitorUrlRequest.swift
• ios/Capacitor/Capacitor/assets/native-bridge.js
• ios/package.json

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• Cap-go/capacitor-updater (manual)

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Preserve insetsHandling: "disable" behavior.

The unconditional injections bypass insetHandlingEnabled, which is set to false when insetsHandling is "disable" at Lines 97-100. Disabled mode will therefore still inject or update --safe-area-inset-* values. Restore the flag check consistently across all three paths.

Also applies to: 194-195, 227-228

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@android/capacitor/src/main/java/com/getcapacitor/plugin/SystemBars.java`
around lines 167 - 178, The safe-area CSS injections in SystemBars must respect
insetHandlingEnabled. Update the injection paths around
calcSafeAreaInsets/injectSafeAreaCSS, including the additional locations at the
referenced paths, to guard all three calls with the flag so insetsHandling:
"disable" neither injects nor updates safe-area values.

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Update package-scope consumers with this rename.

Line [2] changes the public package identity to @capacitor/android, but scripts/sync-peer-dependencies.mjs:8-22 still recognizes only @capacitor-plus/*. The Android package will be skipped, and a corresponding core rename can make corePkg undefined during release preparation.

Proposed synchronization fix

-const CORE_DEPENDENTS = ['`@capacitor-plus/android`', '`@capacitor-plus/ios`'];
+const CORE_DEPENDENTS = ['`@capacitor/android`', '`@capacitor/ios`'];

-const corePkg = pkgs.find((p) => p.name === '`@capacitor-plus/core`');
+const corePkg = pkgs.find((p) => p.name === '`@capacitor/core`');

-await setPackageJsonDependencies(p, { '`@capacitor-plus/core`': range }, 'peerDependencies');
+await setPackageJsonDependencies(p, { '`@capacitor/core`': range }, 'peerDependencies');

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@android/package.json` at line 2, Update the package-scope matching and
core-package resolution in sync-peer-dependencies so the renamed
`@capacitor/android` package is recognized alongside the existing package scope.
Ensure release preparation derives a defined corePkg for the new scope and
preserves synchronization for any remaining `@capacitor-plus` packages.

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Do not manually edit the generated root changelog.

These changes should be produced by the CI/CD release process rather than committed as hand-authored edits. Revert the direct CHANGELOG.md changes and regenerate them through the prescribed pipeline.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` around lines 6 - 30, Revert the hand-authored changes to the
generated root CHANGELOG.md, including the added 8.3.4 and 8.3.3 entries, and
leave changelog updates to the prescribed CI/CD release process.

Source: Path instructions

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Regenerate both changelogs through CI/CD.

The changes in both files violate the repository rule that changelogs are CI/CD-managed artifacts.

• core/CHANGELOG.md#L6-L16: revert the direct 8.3.x edits and regenerate the core changelog.
• ios/CHANGELOG.md#L6-L16: revert the direct 8.3.x edits and regenerate the iOS changelog.

As per coding guidelines, CHANGELOG.md must not be manually edited because it is managed automatically by CI/CD.

📍 Affects 2 files

• core/CHANGELOG.md#L6-L16 (this comment)
• ios/CHANGELOG.md#L6-L16

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/CHANGELOG.md` around lines 6 - 16, Revert the manually added 8.3.x
entries in core/CHANGELOG.md lines 6-16 and regenerate the core changelog
through CI/CD. Apply the same change to ios/CHANGELOG.md lines 6-16; both
changelogs must remain CI/CD-managed artifacts and must not be edited directly.

Source: Coding guidelines

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the source around convertBody and the later response/body handling.
sed -n '1,220p' core/native-bridge.ts
printf '\n--- JS asset (android) ---\n'
sed -n '1,220p' android/capacitor/src/main/assets/native-bridge.js
printf '\n--- JS asset (ios) ---\n'
sed -n '1,220p' ios/Capacitor/Capacitor/assets/native-bridge.js

Repository: Cap-go/capacitor-plus

Length of output: 24063

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Search for downstream classification logic and any tests or references to Uint8Array handling.
rg -n "Uint8Array|ArrayBuffer\.isView|ReadableStream|type: 'binary'|formData|json|text|image|responseType" core/native-bridge.ts android/capacitor/src/main/assets/native-bridge.js ios/Capacitor/Capacitor/assets/native-bridge.js

Repository: Cap-go/capacitor-plus

Length of output: 8273

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python3 - <<'PY'
from pathlib import Path
for p in [
    Path("core/native-bridge.ts"),
    Path("android/capacitor/src/main/assets/native-bridge.js"),
    Path("ios/Capacitor/Capacitor/assets/native-bridge.js"),
]:
    text = p.read_text()
    # Print the exact convertBody block and the later request sending block if present.
    for marker in ["const convertBody", "responseType: 'arraybuffer'", "ArrayBuffer.isView(body)", "body instanceof Uint8Array"]:
        idx = text.find(marker)
        if idx != -1:
            start = max(0, text.rfind("\n", 0, idx-300))
            end = min(len(text), idx+900)
            print(f"\n### {p} :: {marker}\n")
            print(text[start:end])
PY

Repository: Cap-go/capacitor-plus

Length of output: 15826

---

Uint8Array never reaches the content-type-aware branch ArrayBuffer.isView(body) already matches it, so the later body instanceof Uint8Array path is dead. If raw Uint8Array bodies should still be classified by contentType, move that check above the view branch; otherwise remove it and regenerate the Android/iOS bridge assets.

📍 Affects 3 files

• core/native-bridge.ts#L96-L127 (this comment)
• android/capacitor/src/main/assets/native-bridge.js#L94-L126
• ios/Capacitor/Capacitor/assets/native-bridge.js#L94-L126

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/native-bridge.ts` around lines 96 - 127, Resolve the unreachable
Uint8Array handling in the body-encoding branch: move the Uint8Array check
before ArrayBuffer.isView(body) if raw Uint8Array bodies must honor contentType;
otherwise remove the dead Uint8Array path. Apply the same change to
core/native-bridge.ts, android/capacitor/src/main/assets/native-bridge.js, and
ios/Capacitor/Capacitor/assets/native-bridge.js, regenerating the platform
assets when removing the path.