Activity feed: stable ordering for same-timestamp results#132
Open
byte-the-bot wants to merge 1 commit into
Open
Activity feed: stable ordering for same-timestamp results#132byte-the-bot wants to merge 1 commit into
byte-the-bot wants to merge 1 commit into
Conversation
Results from one rating batch share a created_at, so ORDER BY created_at alone let ties come back in arbitrary order and the sidebar reshuffled on every page load. Tiebreak by game then placement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leaderboard sidebar's recent-games feed ordered by
created_atalone. All 2–4 results from one game (and results from games rated in the same batch) share a timestamp, so Postgres returned ties in arbitrary order and entries jumped around when polling the page.Adds
leaderboard_game_id DESC, placement ASCas tiebreakers: deterministic order, one game's results stay grouped, winner first.🤖 Generated with Claude Code