Skip to content

fix(term): run cmd blocks on plain-SSH hosts without wsh #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Atreus-X merged 2 commits into from
Sep 30, 2026
Merged

fix(term): run cmd blocks on plain-SSH hosts without wsh #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cd8d1
fix(term): run the command of a cmd block on a plain-SSH host without…
Atreus-X Sep 30, 2026
fd36cd2
fix(term): keep the terminal open at a prompt after a no-wsh cmd bloc…
Atreus-X Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/blockcontroller/shellcontroller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,14 @@ func (bc *ShellController) startSshShellProcNoWsh(ctx context.Context, rc *RunSh
// tags the shell and everything it starts, so the busy check can find them (busy.go)
cmdOpts.SessionEnv = map[string]string{PlainShellMarkerVar: bc.BlockId}
}
} else if bc.ControllerType == BlockController_Cmd {
// without wsh nothing else runs the command: session.Shell() would just open an idle prompt
// the trailing exec keeps the terminal open at a prompt once the command finishes
// (newlines, not ";", so a trailing comment or multi-line snippet can't swallow it)
sessionCmd = cmdStr + "\n" + `exec "${SHELL:-sh}" -l`
if cmdOpts.Cwd != "" {
sessionCmd = "cd " + utilfn.ShellQuote(cmdOpts.Cwd, false, -1) + "\n" + sessionCmd
}
}
shellProc, err := shellexec.StartRemoteShellProcNoWsh(ctx, rc.TermSize, cmdStr, cmdOpts, conn, sessionCmd)
if err != nil {
Expand Down