Repository navigation
fix(term): run cmd blocks on plain-SSH hosts without wsh - #48
Merged
Merged
Conversation
… wsh Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6
…k finishes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Library Snippets > "Run in new terminal" on a remote host that has no wsh opened a shell but never ran the command. The plain-SSH path (
startSshShellProcNoWsh) ignoredcmdStr: for acmdblock it calledsession.Shell(), so the command was dropped. It now starts the command as the SSH session command (aftercd <cwd>when a working directory is set), thenexecs the login shell so the terminal stays open at a prompt once the command finishes.Also affects anything else that opens a
cmdblock on a no-wsh host, e.g. Host Inspector "open command" actions.Routes
StartWslShellProcNoWsh) also ignorescmdStr; left for a follow-up.Test plan
docker ps, host without wsh, Run in new terminal: output appears and the terminal stays open at a promptdocker ps | head) runs on the no-wsh hostgo vet ./pkg/blockcontroller/clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01W6QMXXvRReaKxWk1JL5Et6