Skip to content

Fix vec3 variant of gltf_image to include scaling factor #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwokcb wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

Fix vec3 variant of gltf_image to include scaling factor #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4de710
Fix gltf_image vec3 to have scale factor as with other variants.
kwokcb Aug 26, 2026
59c9eec
Merge branch 'main' into gltf_image_vec3_factor
kwokcb Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libraries/bxdf/gltf_pbr.mtlx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,7 @@
-->
<nodedef name="ND_gltf_image_vector3_vector3_1_0" node="gltf_image" version="1.0" isdefaultversion="true" nodegroup="texture2d">
<input name="file" type="filename" uniform="true" value="" />
<input name="factor" type="vector3" value="1,1,1" />
<input name="default" type="vector3" value="0, 0, 0" />
<input name="texcoord" type="vector2" defaultgeomprop="UV0" />
<input name="pivot" type="vector2" value="0, 1" />
Expand Down Expand Up @@ -614,7 +615,11 @@
<input name="offset" type="vector2" nodename="negate_offset" />
<input name="operationorder" type="integer" interfacename="operationorder" />
</place2d>
<output name="out" type="vector3" nodename="image" />
<multiply name="scale_image" type="vector3">
<input name="in1" type="vector3" interfacename="factor" />
<input name="in2" type="vector3" nodename="image" />
</multiply>
<output name="out" type="vector3" nodename="scale_image" />
</nodegraph>

<!---
Expand Down
2 changes: 2 additions & 0 deletions resources/Materials/Examples/GltfPbr/gltf_pbr_boombox.mtlx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
<materialx version="1.39" colorspace="lin_rec709" fileprefix="boombox/">
<gltf_colorimage name="image_basecolor" type="multioutput">
<input name="file" type="filename" value="BoomBox_baseColor.png" colorspace="srgb_texture" />
<input name="color" type="color4" value="1.0, 1.0, 1.0, 1.0" />
</gltf_colorimage>
<gltf_image name="image_orm" type="vector3">
<input name="file" type="filename" value="BoomBox_occlusionRoughnessMetallic.png" />
<input name="factor" type="vector3" value="1.0, 1.0, 1.0" />
</gltf_image>
<gltf_normalmap name="image_normal" type="vector3">
<input name="file" type="filename" value="BoomBox_normal.png" />
Expand Down
Loading