ci: key E2E workflow_dispatch concurrency on head_sha - #1367
Open
jiagaoxiang wants to merge 2 commits into
Open
Conversation
The Forge gate counted the old group string (0==2 after the workflow change). CI E2E's guard only required github.ref, which is how two dispatches shared refs/heads/main and cancelled each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchhas nopull_request.number/issue.number, so CI E2E concurrency fell through togithub.ref(refs/heads/mainfor every dispatch).cancel-in-progress: truethen killed the previous GPU smoke — #1325's dispatch cancelled #1322's run 33463143636 after ~58 min on the GPU.This keys the group on
inputs.head_sha(theninputs.head_ref) beforegithub.ref, so two fork-PR dispatches can coexist. Same idea on Forge E2E job concurrency (head_shabeforehead_ref).forge-kernel-bench.ymlalready uses a singleforge-kernel-benchgroup withcancel-in-progress: false, so dispatches serialize instead of killing each other. Left it alone.Test plan
head_shas frommainand confirm the first run is not cancelled/retest/retestlabel path still cancels the same-PR in-flight run