test: pin verify_cpp_itfs_rebuilt freshness branches (PRPUNDIT-7) - #1322
Open
jiagaoxiang wants to merge 2 commits into
Open
test: pin verify_cpp_itfs_rebuilt freshness branches (PRPUNDIT-7)#1322jiagaoxiang wants to merge 2 commits into
jiagaoxiang wants to merge 2 commits into
Conversation
Cover the KEEP/REVERT cpp_itfs rebuild gate, including empty build_dir, mtime slack, and module glob fallback.
Reject Path('') so verification cannot glob the process CWD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_cpp_itfs_rebuiltKEEP/REVERT freshness branches: non-cpp_itfs skip, absent/emptybuild_dir, stale vs freshlib.so, 1s mtime slack, and emptymodule_namesglob fallback.build_dirguard soPath('')cannot glob the process CWD (reviewer yihanwan found this live hole).Closes test gap PRPUNDIT-7.
Test plan
PYTHONPATH=src pytest src/hyperloom/agents/kernel/tests/test_apply_kernel_patch_isolated_aiter.py -k verify_cpp_itfs_rebuilt