Repository navigation
Link every download to the latest GitHub release - #2
Merged
Merged
Conversation
The website, handbook and README link the Android APK and the source archive at github.com/AKolenda/openfuel/releases/latest/download/, and the site no longer bundles them under /downloads. A new release-assets command collects the APK, its checksum and the source archive in dist/release for a GitHub release; the build still packages the source archive for the checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/AKolenda/openfuel/releases/latest/download/. The links areopenfuel-android.apkandopenfuel-source.zip./downloads. The_headersrules for them are removed.python3 tools/project.py release-assetscollects the three files for a release indist/release/: the APK, its.sha256checksum and the source archive. The site build still packages the source archive, because the checks inspect it.sourceURLand.env.examplepoint at the release asset.Release
A release must attach exactly those file names and must not be a pre-release, so that
releases/latestresolves to it. The first release is created after this merges, before the site is redeployed, so the links never point at nothing.Testing
pytest testsThe browser checks now assert the new link targets and inspect
dist/openfuel-source.zipdirectly.dist/site/downloadsis no longer produced.