Skip to content

Fix elastic checkpoint save/restore goodput/badput calculation edge cases. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 1, 2026
Merged

Fix elastic checkpoint save/restore goodput/badput calculation edge cases. #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 40 additions & 26 deletions ml_goodput_measurement/src/checkpoint_badput_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,11 @@ def _save_statistics(
)
return vertical_step_stats

@staticmethod
def _get_duration_stat(step_stats: Dict[str, str], key: str) -> float:
"""Safely extracts a float duration in seconds, defaulting None to 0.0."""
return float(step_stats.get(key) or 0.0)

def calculate_save_operation_checkpoint_manager_blocking_time(
self, operation_type: Optional[str] = OPERATION_TYPE_PERSISTENT_AND_LOCAL,
) -> SaveCheckpointManagerVerticalStepStats:
Expand All @@ -408,36 +413,42 @@ def calculate_save_operation_checkpoint_manager_blocking_time(
step_already_processed[step_info].step = step_info
step_already_processed[
step_info
].total_checkpoint_manager_blocking_time = float(
step_stats[_CHECKPOINT_MANAGER_SAVE_DURATION_SECS]
].total_checkpoint_manager_blocking_time = self._get_duration_stat(
step_stats, _CHECKPOINT_MANAGER_SAVE_DURATION_SECS
)
step_already_processed[step_info].total_checkpointer_blocking_time = (
float(step_stats[_CHECKPOINTER_SAVE_DURATION_SECS])
self._get_duration_stat(
step_stats, _CHECKPOINTER_SAVE_DURATION_SECS
)
)
step_already_processed[step_info].total_wait_for_prev_time = float(
step_stats[_WAIT_FOR_PREV_DURATION_SECS]
step_already_processed[step_info].total_wait_for_prev_time = (
self._get_duration_stat(step_stats, _WAIT_FOR_PREV_DURATION_SECS)
)
step_already_processed[step_info].total_get_old_steps_time = float(
step_stats[_GET_OLD_STEPS_DURATION_SECS]
step_already_processed[step_info].total_get_old_steps_time = (
self._get_duration_stat(step_stats, _GET_OLD_STEPS_DURATION_SECS)
)
step_already_processed[step_info].occurrence = 1
else:
step_already_processed[step_info].step = step_info
step_already_processed[
step_info
].total_checkpoint_manager_blocking_time += float(
step_stats[_CHECKPOINT_MANAGER_SAVE_DURATION_SECS]
].total_checkpoint_manager_blocking_time += self._get_duration_stat(
step_stats, _CHECKPOINT_MANAGER_SAVE_DURATION_SECS
)
step_already_processed[
step_info
].total_checkpointer_blocking_time += float(
step_stats[_CHECKPOINTER_SAVE_DURATION_SECS]
].total_checkpointer_blocking_time += self._get_duration_stat(
step_stats, _CHECKPOINTER_SAVE_DURATION_SECS
)
step_already_processed[step_info].total_wait_for_prev_time += float(
step_stats[_WAIT_FOR_PREV_DURATION_SECS]
step_already_processed[
step_info
].total_wait_for_prev_time += self._get_duration_stat(
step_stats, _WAIT_FOR_PREV_DURATION_SECS
)
step_already_processed[step_info].total_get_old_steps_time += float(
step_stats[_GET_OLD_STEPS_DURATION_SECS]
step_already_processed[
step_info
].total_get_old_steps_time += self._get_duration_stat(
step_stats, _GET_OLD_STEPS_DURATION_SECS
)
step_already_processed[step_info].occurrence += 1

Expand Down Expand Up @@ -591,11 +602,15 @@ def calculate_restore_operation_checkpoint_manager_blocking_time(
step_already_processed[step_info] = RestoreProcessedStep()
step_already_processed[step_info].step = step_info

step_already_processed[step_info].total_checkpoint_manager_time = float(
step_stats[_CHECKPOINT_MANAGER_RESTORE_DURATION_SECS]
step_already_processed[step_info].total_checkpoint_manager_time = (
self._get_duration_stat(
step_stats, _CHECKPOINT_MANAGER_RESTORE_DURATION_SECS
)
)
step_already_processed[step_info].total_restore_time = float(
step_stats[_CHECKPOINTER_RESTORE_DURATION_SECS]
step_already_processed[step_info].total_restore_time = (
self._get_duration_stat(
step_stats, _CHECKPOINTER_RESTORE_DURATION_SECS
)
)
if (
step_stats.get(_BROADCAST_DURATION_SECS)
Expand All @@ -610,11 +625,13 @@ def calculate_restore_operation_checkpoint_manager_blocking_time(
step_already_processed[step_info].step = step_info
step_already_processed[
step_info
].total_checkpoint_manager_time += float(
step_stats[_CHECKPOINT_MANAGER_RESTORE_DURATION_SECS]
].total_checkpoint_manager_time += self._get_duration_stat(
step_stats, _CHECKPOINT_MANAGER_RESTORE_DURATION_SECS
)
step_already_processed[step_info].total_restore_time += float(
step_stats[_CHECKPOINTER_RESTORE_DURATION_SECS]
step_already_processed[
step_info
].total_restore_time += self._get_duration_stat(
step_stats, _CHECKPOINTER_RESTORE_DURATION_SECS
)
if (
step_stats.get(_BROADCAST_DURATION_SECS)
Expand Down Expand Up @@ -671,6 +688,3 @@ def calculate_restore_operation_checkpoint_manager_blocking_time(
checkpoint_badput_calculator.calculate_save_operation_checkpoint_manager_blocking_time(
args.operation_type
)



Loading
Loading