Repository navigation
Fix elastic checkpoint save/restore goodput/badput calculation edge cases. - #21
Merged
Merged
Conversation
copybara-service
Bot
requested review from
YixuanWang-99,
abhinavclemson,
bvandermoon,
dipannita08,
richjames0 and
shralex
as code owners
September 28, 2026 20:12
copybara-service
Bot
force-pushed
the
test_988387142
branch
2 times, most recently
from
October 1, 2026 18:35
9564e16 to
4b7351b
Compare
copybara-service
Bot
changed the title
dipannita08
changed the title
…lation edge cases. END_PUBLIC Fix elastic and checkpoint goodput/badput calculation edge cases This change fixes several Goodput and Badput calculation and crash issues for elastic and checkpointed workloads: - Detect in-process elastic restarts (`elastic_wait_start_time` / `elastic_reinit_start_time`) in `ElasticGoodputCalculator` when `job_start_time` is not logged. - Discount `UNPRODUCTIVE_CHECKPOINT_RESTORE_TIME` overlap within `ELASTIC_REINITIALIZATION` intervals alongside `TPU_INITIALIZATION` and `TRAINING_PREP`. - Deduct synchronous checkpoint save blocking time per step before computing `PROGRAM_STARTUP` (`startup_extra_time`), and avoid subtracting checkpoint save badput for uncompleted tail steps. - Use historical step times as fallback baseline when a post-restart segment has only a single completed step. - Exclude duration and `None` fields in `get_timestamp_from_log_entry` and safely handle `None` checkpoint durations in `CheckpointBadputCalculator`. - Make step deviation and ideal step time calculations restart- and checkpoint-aware. PiperOrigin-RevId: 991804459
copybara-service
Bot
force-pushed
the
test_988387142
branch
from
October 1, 2026 18:39
4b7351b to
c67e909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix elastic checkpoint save/restore goodput/badput calculation edge cases.