Repository navigation
Verify page: don't let the action bar cover the email when embedded - #32
Merged
Merged
Conversation
…edded In an iframe (e.g. a blog embedding a proof) the viewport is short, so the fixed bottom bar sat on top of the email text and, below md, showed only an unlabeled icon. When embedded, render the bar in normal flow after the email; always label the verify button; reserve bottom padding on the standalone page so the end of the email can scroll clear of the fixed bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Human intent
Aayush embeds Redacted verify pages in his blog (an iframe per proof). In the embed, a floating icon sat on top of the email text and looked like a stray logo. He asked to fix the website so embeds show the email accurately.
Cause
ActionBarisposition: fixedat the bottom of the viewport. Inside a ~720 px iframe that is mid-email, so it covered the text, and below themdbreakpoint its label is hidden, leaving only the icon.Change
VerifyPage: detect being iframed (window.self !== window.top, treating a throw as embedded) and render the bar inline after the email instead of fixed.ActionBar: newinlineprop; the Verify Proof label is always shown, so it's never an unlabeled icon.pb-32onmainso the end of the email can scroll clear of the fixed bar.The standalone layout is otherwise unchanged.
Checks
yarn tsc -bandvite buildpass.viteagainst the production API, iframed two real verify pages at 720 px, and confirmed the bar renders below the email card, labeled "Verify Proof", with no overlap (screenshot in a comment below).🤖 Generated with Claude Code
Summary by CodeRabbit