Repository navigation
Fix production build (broken since #26) and make CI type-check like the build - #30
Merged
Merged
Conversation
…w runs tsc -b Render's Docker build runs 'yarn build' (tsc -b && vite build) and has failed since 7313499 (#26): EmailCard passed string[] | undefined, and decodeMaskedBytes passed unknown elements after reassigning its readonly unknown[] parameter. Production stayed on ac35414, so #26's security fixes and #29 never went live. CI ran 'tsc --noEmit' on the root tsconfig, whose files: [] means it checked nothing; it now runs 'tsc -b' like the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…w to confirm a deploy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human intent
#29 was merged but never appeared on redacted.zk.email. Get it live.
Cause
Every Render deploy since #26 (7313499, 2026-10-01) failed at
yarn build, which runstsc -b && vite build, with 5 type errors:EmailCard.tsx:unplacedRedactionscan be undefined.proofOutputs.ts:decodeMaskedBytesreassigned itsreadonly unknown[]parameter, so its elements stayedunknown.So production stayed on
ac35414(#25), and #26's security fixes and #29 never went live. CI didn't catch it: it ranyarn tsc --noEmiton the root tsconfig, which has"files": []and project references, so it type-checked nothing.Fix
yarn tsc -b, the same check the production build runs.Verification
tsc -b: clean (5 errors on main).vite build: OK.🤖 Generated with Claude Code