fix: fetch price over clearnet when Mixnet Mode is off - #1340
Conversation
Point zingolib at the clearnet_price_when_switched_off branch (zingolib PR #2747): update_current_price now consents to a clearnet fetch while Mixnet Mode is switched off, and PriceFetchRequiresMixnet is gone. Adapt the FFI error funnel to the removed variant and the NoEligibleCorrespondent -> NoEligibleDestination rename, and align the android test crate's zcash_local_net pin with the branch. Repin to a tag before this lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zingolib PR #2747 merged as eb62284f; the three pins move from the PR branch to dev. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
5334ed7 to
b11e71f
Compare
juanky201271
left a comment
juanky201271
left a comment
There was a problem hiding this comment.
Two things block the stated goal ("price fetch now works without nym"), plus a repin nit — inline.
Minor: after the Correspondent -> Destination rename the prose still says Correspondent in rust/lib/src/lib.rs (351, 611, 627) and app/walletBackend/utils/walletUtils.ts:84. The package.json beta script and the Dockerfile --bin fix look correct, but they are unrelated to the title.
Visual review — ✅ matches baselineHead vs |
juanky201271
left a comment
juanky201271
left a comment
There was a problem hiding this comment.
The gate moves the right way now, but the opt-in transition opens a clearnet fetch — inline.
Also: CONTEXT.md still carries the deleted ADR's rule in the glossary — Route ("A price fetch that resolves to clearnet is refused, never sent") and Price consent ("Selecting Nym ... the single and only consent for price traffic"). Those two entries now contradict the code and should move with it.
Still open from the last round: branch = "dev" in rust/Cargo.toml.
3 participants
Integrates zingolabs/zingolib#2747: price fetch now works without nym!